types/Coin: compile and reuse Regexps to reduce massive RAM+CPU burn #8001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…7989) From: #7989 Closes: #7986 Co-authored-by: Federico Kunze <[email protected]> Co-authored-by: Alessio Treglia <[email protected]>
Codecov Report
@@ Coverage Diff @@
## launchpad/backports #8001 +/- ##
====================================================
Coverage 50.29% 50.30%
====================================================
Files 338 338
Lines 17570 17572 +2
====================================================
+ Hits 8837 8839 +2
Misses 7940 7940
Partials 793 793
|
fedekunze
approved these changes
Nov 21, 2020
okwme
approved these changes
Nov 23, 2020
alexanderbez
suggested changes
Nov 23, 2020
alessio
commented
Nov 23, 2020
alessio
commented
Nov 23, 2020
Co-authored-by: Alessio Treglia <[email protected]>
alexanderbez
approved these changes
Nov 23, 2020
ethanfrey
approved these changes
Nov 23, 2020
clevinson
approved these changes
Nov 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch brings a client code breaking change. As such it requires a Stable Release Exception to be granted by the Stable Release Managers. @clevinson @ethanfrey
From: #7989
Closes: #7986
Co-authored-by: Federico Kunze [email protected]
Co-authored-by: Alessio Treglia [email protected]
Impact
The changes introduced in #7450 to support denoms custom validation
caused a significance performance hit due to the use of closures
instead of compiled regular expressions. As the reporter described in #7986,
this represents a security threat since many ParseCoin invocations made
concurrently could cause the client application to run out of RAM.
Test Case
The bug becomes visible by invoking ParseCoin concurrently 1000 times.
A benchmark test case is included in this PR.
Regression Potential
Regressions could manifest if the
CoinDenomRegexwas left publicly exposedas any modification to it by the client would not trigger the recompilation of the
regular expressions that depend on it. The original patch addresses potential
regressions by replacing
CoinDenomRegexwith the accessorSetCoinDenomRegex()in the the
typespackage public interface.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes