Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update RELEASE_NOTES.md #7858

Merged
merged 2 commits into from
Nov 13, 2020
Merged

update RELEASE_NOTES.md #7858

merged 2 commits into from
Nov 13, 2020

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Nov 9, 2020

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@alessio alessio requested a review from tac0turtle November 9, 2020 15:03
ethanfrey
ethanfrey approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

RELEASE_NOTES.md Show resolved Hide resolved
@alessio
Copy link
Contributor Author

alessio commented Nov 9, 2020

@clevinson This needs your approval

@alessio alessio merged commit 1bbffff into launchpad/backports Nov 13, 2020
@alessio alessio deleted the alessio/launchpad-0392-release-notes branch November 13, 2020 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfrey ethanfrey ethanfrey approved these changes

@clevinson clevinson clevinson approved these changes

@tac0turtle tac0turtle Awaiting requested review from tac0turtle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alessio @clevinson @ethanfrey