Flexible Connection Handshake Selection #7427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update ConnOpenInit to reflect changes in cosmos/ibc#482. An additional version field is added to the connection handshake and connection open init message to take in an optional field. If this field is empty, then the default versions are used for connection handshake version negotiation.
colin-axner
requested review from
aaronc,
alessio and
alexanderbez
as code owners
|
supersedes: #7431 |
|
missing docs updates, but I think this is ready. Only handles connection handshake changes. I'll do channel changes in a separate pr |
colin-axner
changed the title
Codecov Report
@@ Coverage Diff @@
## master #7427 +/- ##
==========================================
+ Coverage 55.07% 55.21% +0.13%
==========================================
Files 588 435 -153
Lines 36760 28810 -7950
==========================================
- Hits 20245 15906 -4339
+ Misses 14417 11301 -3116
+ Partials 2098 1603 -495 |
colin-axner
changed the title
9 tasks
cwgoes
approved these changes
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref: #7025
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes