Add key recover test #7183
Merged
Add key recover test #7183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7183 +/- ##
==========================================
+ Coverage 54.74% 54.78% +0.04%
==========================================
Files 563 563
Lines 38624 38624
==========================================
+ Hits 21145 21162 +17
+ Misses 15748 15730 -18
- Partials 1731 1732 +1 |
alessio
reviewed
Aug 27, 2020
alexanderbez
added
A:automerge
alessio
approved these changes
Aug 28, 2020
9 tasks
alessio
pushed a commit
that referenced
this pull request
Aug 28, 2020
Fix the command line `keys add` interactive mode that fails when asked to generate new mnemonic. Closes: #7048 From: - #7049 - #7183 Thanks: @puneet2019 @PaddyMc for the patches.
alessio
pushed a commit
that referenced
this pull request
Aug 31, 2020
Fix the command line `keys add` interactive mode that fails when asked to generate new mnemonic. Closes: #7048 From: - #7049 - #7183 Thanks: @puneet2019 @PaddyMc for the patches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add tests for #7049
Closes: #7179
How to test
Run:
make testsee all passing test
Or
go test -run client/keys/add_test.gosee passing test
🤝
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes