Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unblock CI on Launchpad #7088

Merged
merged 1 commit into from
Aug 19, 2020
Merged

unblock CI on Launchpad #7088

merged 1 commit into from
Aug 19, 2020

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Aug 18, 2020 •
edited
Loading

Thanks: @marbar3778 for the patch.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@alessio alessio force-pushed the launchpad-fix-ci branch 2 times, most recently from f7a46d4 to fe56d73 Compare August 18, 2020 16:16
@alessio alessio added this to the 0.39.2 - The Launchpad Series milestone Aug 18, 2020
@alessio alessio requested review from clevinson and ethanfrey August 18, 2020 16:21
unblock CI on Launchpad
311c50d 
Replace old actions that don't build anymore.
@alessio alessio changed the title try unblock CI on Launchpad unblock CI on Launchpad Aug 18, 2020
ethanfrey
ethanfrey approved these changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alessio alessio merged commit 86f953b into launchpad/backports Aug 19, 2020
@alessio alessio deleted the launchpad-fix-ci branch August 19, 2020 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedekunze fedekunze fedekunze approved these changes

@tac0turtle tac0turtle tac0turtle approved these changes

@ethanfrey ethanfrey ethanfrey approved these changes

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@clevinson clevinson Awaiting requested review from clevinson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.39.2 - The Launchpad Series
Development

Successfully merging this pull request may close these issues.
4 participants
@alessio @ethanfrey @tac0turtle @fedekunze