Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tests build failures with go1.15 #7073

Merged
merged 1 commit into from
Aug 18, 2020

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Aug 17, 2020

Go1.15 has become stricter with conversions from string.
See https://golang.org/doc/go1.15#vet


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@alessio
Copy link
Contributor Author

alessio commented Aug 17, 2020

@ethanfrey @clevinson please review

@codecov
Copy link

codecov bot commented Aug 17, 2020

Codecov Report

❗ No coverage uploaded for pull request base (launchpad/backports@6a624c3). Click here to learn what that means.
The diff coverage is n/a.

@@                  Coverage Diff                   @@
##             launchpad/backports    #7073   +/-   ##
======================================================
  Coverage                       ?   51.51%           
======================================================
  Files                          ?      338           
  Lines                          ?    20585           
  Branches                       ?        0           
======================================================
  Hits                           ?    10605           
  Misses                         ?     9185           
  Partials                       ?      795           

Copy link
Contributor

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. And I learned that Sprint works without the trailing f

@alessio alessio merged commit c7d0b5a into launchpad/backports Aug 18, 2020
@alessio alessio deleted the alessio/0.39.2-go1.15 branch August 18, 2020 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants