update sims operations to use baseapp #4946

fedekunze · 2019-08-22T15:53:44Z

closes #4935
closes #2778

NOTE FOR REVIEWER: please review with extreme detail. These changes affect all the simulation operations (randomized msgs) which are our best tools for identifying bugs on the code.

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (docs/)
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the github PR explorer

For Admin Use:

Added appropriate labels to PR (ex. wip, ready-for-review, docs)
Reviewers Assigned
Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

x/gov/types/expected_keepers.go

x/bank/simulation/operations/msgs.go

x/gov/simulation/operations/msgs.go

x/distribution/simulation/operations/msgs.go

x/slashing/simulation/operations/msgs.go

x/staking/simulation/operations/msgs.go

…dekunze/4935-sim-ops-baseapp

x/bank/simulation/operations/msgs.go

x/gov/simulation/operations/msgs.go

…dekunze/4935-sim-ops-baseapp

fedekunze · 2019-08-28T15:56:16Z

simapp/helpers/test_helpers.go

+)
+
+// GenTx generates a signed mock transaction.
+func GenTx(msgs []sdk.Msg, accnums []uint64, seq []uint64, priv ...crypto.PrivKey) auth.StdTx {


ideally, we should move all the contents from simapp/test_helpers.go to this file and update the keepers that use it, although that's out of scope from this PR. cc: @colin-axner

codecov · 2019-08-28T15:59:20Z

Codecov Report

Merging #4946 into master will decrease coverage by 0.01%.
The diff coverage is 4.34%.

@@            Coverage Diff             @@
##           master    #4946      +/-   ##
==========================================
- Coverage   53.55%   53.54%   -0.02%     
==========================================
  Files         290      290              
  Lines       17719    17719              
==========================================
- Hits         9489     9487       -2     
- Misses       7489     7491       +2     
  Partials      741      741

x/distribution/simulation/operations.go

alexanderbez · 2019-09-30T23:49:02Z

x/slashing/simulation/operations.go

+		}
+
+		if !validator.IsJailed() {
+			// TODO: due to this condition this message is almost, if not always, skipped !


What are we to do with this TODO?

actually nothing on this PR. None of the validators is jailed. Idk if that's a problem of the simulator itself

we should simulate that by having the undelgate operation sometimes have a validator undelegate below its min delegation causing it to be jailed.

x/slashing/simulation/operations.go

x/bank/simulation/operations.go

x/staking/simulation/operations.go

AdityaSripal · 2019-10-18T22:40:12Z

x/simulation/rand_util.go

+// returns random subset of the provided coins
+// will return at least one coin unless coins argument is empty or malformed
+// i.e. 0 amt in coins
+func RandSubsetCoins(r *rand.Rand, coins sdk.Coins) sdk.Coins {


I want to use this for RandomFees as well so fees can be paid in multiple coins rather than just one denom. Thoughts?

Yeah I think that's fine.

x/simulation/account.go

x/slashing/simulation/operations.go

simapp/state.go

alexanderbez · 2019-10-22T15:51:45Z

x/auth/simulation/genesis.go

 func GenTxSigLimit(r *rand.Rand) uint64 {
-	return uint64(r.Intn(7) + 1)
+	return uint64(r.Intn(7) + 5)


irc, the +1 is to just make sure it's never 0. Why not r.Intn(12)+1?

alexanderbez

ACK 🎉

x/simulation/account.go

x/slashing/simulation/operations.go

fedekunze

tested ACK

@colin-axner

* update operations to use baseapp * updates and cleanup operations * update operations * restructure sim ops params * rename sim /operations/msg.go to /operations.go * move GenTx to a helper pkg to avoid circle deps * rm msg.ValidateBasic * changelog * random fees; delete auth's DeductFees sim operation * add chain-id for sig verification * Update x/simulation/account.go Co-Authored-By: colin axner <[email protected]> * fix bank, gov and distr errors * fix staking and slashing errors; increase prob for send enabled * increase gas x10 * make format * fix some distr and staking edge cases * fix all edge cases * golang ci * rename acc vars; default no fees to 0stake * cleanup; check for exchange rate and skip invalid ops * fixes * check for max entries * add pubkey to genaccounts * fix gov bug * update staking sim ops * fix small redelegation error * fix small self delegation on unjail * rm inf loop on random val/accs * copy array * add ok boolean to RandomValidator return values * format * Update x/bank/simulation/operations.go Co-Authored-By: colin axner <[email protected]> * Update simapp/helpers/test_helpers.go Co-Authored-By: colin axner <[email protected]> * address @colin-axner comments * add genaccount pubkey validation * fix test * update operations and move RandomFees to x/simulation * update gov ops * address @alexanderbez comments * avoid modifications to config * reorder params * changelog * Update x/distribution/simulation/genesis.go Co-Authored-By: Alexander Bezobchuk <[email protected]> * remove named return values * ensure all operations are simulated * golangci * add nolint * disable whitespace and funlen linter * disable godox * add TODO on unjail * update ops weights * remove dup * update godoc * x/slashing/simulation/operations.go linting * x/staking/simulation/operations.go linting * update operations format * x/bank/simulation/operations.go linting * x/distribution/simulation/operations.go linting * x/staking/simulation/operations.go linting * start changes: make bank simulate send multiple coins, code cleanup * fix nondeterminism bug * fix txsiglimit err * fix multisend bug * simplify simulation, cleanup opt privkey args * make slashing test invalid unjail msgs * Update simapp/state.go * golangCI changes

update operations to use baseapp

f22313a

fedekunze added the WIP label Aug 22, 2019

fedekunze changed the title ~~update operations to use baseapp~~ update sims operations to use baseapp Aug 22, 2019

golangcibot reviewed Aug 22, 2019

View reviewed changes

fedekunze added 2 commits August 26, 2019 15:58

Merge branch 'master' of https://github.com/cosmos/cosmos-sdk into fe…

8f1240c

…dekunze/4935-sim-ops-baseapp

updates and cleanup operations

5a31d65

golangcibot reviewed Aug 26, 2019

View reviewed changes

x/bank/simulation/operations/msgs.go Outdated Show resolved Hide resolved

x/bank/simulation/operations/msgs.go Outdated Show resolved Hide resolved

x/gov/simulation/operations/msgs.go Outdated Show resolved Hide resolved

fedekunze added 7 commits August 27, 2019 11:37

Merge branch 'master' of https://github.com/cosmos/cosmos-sdk into fe…

89cf7b9

…dekunze/4935-sim-ops-baseapp

update operations

5f606ea

restructure sim ops params

d450ebb

merge master

abb288f

merge master

51bf12b

rename sim /operations/msg.go to /operations.go

fe3f6f3

move GenTx to a helper pkg to avoid circle deps

f3a398b

fedekunze added C:baseapp R4R C:Simulations and removed WIP labels Aug 28, 2019

fedekunze marked this pull request as ready for review August 28, 2019 15:45

fedekunze requested review from alessio, alexanderbez, jackzampolin and rigelrozanski as code owners August 28, 2019 15:45

fedekunze requested review from colin-axner and tnachen August 28, 2019 15:46

fedekunze commented Aug 28, 2019

View reviewed changes

rm msg.ValidateBasic

666a301

golangcibot reviewed Aug 28, 2019

View reviewed changes

x/distribution/simulation/operations.go Show resolved Hide resolved

changelog

1bb0adc

Merge branch 'master' into fedekunze/4935-sim-ops-baseapp

0bf30c3

fedekunze requested a review from alexanderbez October 1, 2019 06:55

fedekunze self-assigned this Oct 1, 2019

alexanderbez added 3 commits October 1, 2019 17:14

x/bank/simulation/operations.go linting

7c3314e

x/distribution/simulation/operations.go linting

4a24fb8

x/staking/simulation/operations.go linting

a15b55f

alexanderbez suggested changes Oct 2, 2019

View reviewed changes

merge master

95f0b04

AdityaSripal self-assigned this Oct 16, 2019

AdityaSripal added 6 commits October 16, 2019 17:26

start changes: make bank simulate send multiple coins, code cleanup

42fd548

fix nondeterminism bug

0c65eda

fix txsiglimit err

cf215f8

fix multisend bug

99baf18

simplify simulation, cleanup opt privkey args

33ee0e0

make slashing test invalid unjail msgs

bc1027d

AdityaSripal reviewed Oct 18, 2019

View reviewed changes

Merge branch 'master' into fedekunze/4935-sim-ops-baseapp

202fe2b

golangcibot reviewed Oct 22, 2019

View reviewed changes

x/simulation/account.go Outdated Show resolved Hide resolved

x/slashing/simulation/operations.go Outdated Show resolved Hide resolved

x/slashing/simulation/operations.go Outdated Show resolved Hide resolved

x/slashing/simulation/operations.go Outdated Show resolved Hide resolved

alexanderbez reviewed Oct 22, 2019

View reviewed changes

Update simapp/state.go

716d00d

alexanderbez approved these changes Oct 22, 2019

View reviewed changes

golangcibot reviewed Oct 22, 2019

View reviewed changes

x/simulation/account.go Outdated Show resolved Hide resolved

x/slashing/simulation/operations.go Outdated Show resolved Hide resolved

x/slashing/simulation/operations.go Outdated Show resolved Hide resolved

x/slashing/simulation/operations.go Outdated Show resolved Hide resolved

golangCI changes

6ed2005

fedekunze commented Oct 23, 2019

View reviewed changes

fedekunze merged commit 8344c0a into master Oct 23, 2019

alexanderbez deleted the fedekunze/4935-sim-ops-baseapp branch November 4, 2019 18:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update sims operations to use baseapp #4946

update sims operations to use baseapp #4946

fedekunze commented Aug 22, 2019 •

edited

Loading

fedekunze Aug 28, 2019 •

edited

Loading

codecov bot commented Aug 28, 2019 •

edited

Loading

alexanderbez Sep 30, 2019

fedekunze Oct 2, 2019 •

edited

Loading

alexanderbez Oct 3, 2019

AdityaSripal Oct 18, 2019

alexanderbez Oct 21, 2019

alexanderbez Oct 22, 2019

alexanderbez left a comment

fedekunze left a comment

update sims operations to use baseapp #4946

update sims operations to use baseapp #4946

Conversation

fedekunze commented Aug 22, 2019 • edited Loading

fedekunze Aug 28, 2019 • edited Loading

Choose a reason for hiding this comment

codecov bot commented Aug 28, 2019 • edited Loading

Codecov Report

alexanderbez Sep 30, 2019

Choose a reason for hiding this comment

fedekunze Oct 2, 2019 • edited Loading

Choose a reason for hiding this comment

alexanderbez Oct 3, 2019

Choose a reason for hiding this comment

AdityaSripal Oct 18, 2019

Choose a reason for hiding this comment

alexanderbez Oct 21, 2019

Choose a reason for hiding this comment

alexanderbez Oct 22, 2019

Choose a reason for hiding this comment

alexanderbez left a comment

Choose a reason for hiding this comment

fedekunze left a comment

Choose a reason for hiding this comment

fedekunze commented Aug 22, 2019 •

edited

Loading

fedekunze Aug 28, 2019 •

edited

Loading

codecov bot commented Aug 28, 2019 •

edited

Loading

fedekunze Oct 2, 2019 •

edited

Loading