Save sim params and export app state to file #4731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedekunze
requested review from
alessio,
alexanderbez,
jackzampolin and
rigelrozanski
as code owners
fedekunze
requested review from
mircea-c,
colin-axner,
tac0turtle and
greg-szabo
Codecov Report
@@ Coverage Diff @@
## master #4731 +/- ##
==========================================
- Coverage 53.92% 53.91% -0.02%
==========================================
Files 273 273
Lines 17367 17367
==========================================
- Hits 9366 9364 -2
- Misses 7317 7319 +2
Partials 684 684 |
alessio
approved these changes
Jul 18, 2019
|
I need to do some cleanup still. Moving back to WIP |
alexanderbez
suggested changes
Jul 19, 2019
| @@ -48,11 +54,13 @@ func init() { | |||
| // helper function for populating input for SimulateFromSeed | |||
| func getSimulateFromSeedInput(tb testing.TB, w io.Writer, app *SimApp) ( | |||
There was a problem hiding this comment.
sighh...this function is becoming overwhelmingly verbose and hard to grok.
There was a problem hiding this comment.
agree... I'd like to do some refactors later on the simulator and this is one of the things that'd be cleaned up
Co-Authored-By: Alexander Bezobchuk <[email protected]>
…osmos/cosmos-sdk into fedekunze/4566-save-sim-params
mircea-c
suggested changes
Jul 19, 2019
Co-Authored-By: mircea-c <[email protected]>
…osmos/cosmos-sdk into fedekunze/4566-save-sim-params
alexanderbez
pushed a commit
that referenced
this pull request
Jul 23, 2019
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4566
cc: @npinto
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
clog add [section] [stanza] [message]rereviewed
Files changedin the github PR explorerFor Admin Use: