Modify stake to uatom in gaia's doc. #3833

[yangyanqing]

• Targeted PR against correct branch (see CONTRIBUTING.md)

• Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

• Wrote tests

• Updated relevant documentation (docs/)

• Added a relevant changelog entry: sdkch add [section] [stanza] [message]

• rereviewed Files changed in the github PR explorer

---

For Admin Use:

• Added appropriate labels to PR (ex. wip, ready-for-review, docs)
• Reviewers Assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[codecov]

Codecov Report

Merging #3935 into develop will decrease coverage by 0.01%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop    #3935      +/-   ##
===========================================
- Coverage    60.26%   60.25%   -0.02%     
===========================================
  Files          196      196              
  Lines        14615    14615              
===========================================
- Hits          8808     8806       -2     
- Misses        5214     5216       +2     
  Partials       593      593

[fedekunze]

should be uatom instead of atom

[yangyanqing]

should be uatom instead of atom

Denom in genesis.json is uatom. atom should be the demon when value was decimal, because uatom is an indivisible denom.

We are preparing to add multi-demon to sdk.

{
  ...
  "app_state": {
    "accounts": [
      {
        "address": "cosmos1000ya26q2cmh399q4c5aaacd9lmmdqp92z6l7q",
        "coins": [
          {
            "denom": "uatom",
            "amount": "5000000000"
          }
        ],
        "sequence_number": "0",
        "account_number": "0",
        "original_vesting": null,
        "delegated_free": null,
        "delegated_vesting": null,
        "start_time": "0",
        "end_time": "0"
      },
    ]
    ...
}

[rigelrozanski]

Many instances where stake should still be used otherwise, uatom should be used or mainnet documentation (not atom)... see my detailed comments

RE: your most recent comment - we should still use uatom in the documentation for the time being, when we make the switch then we can switch the docs

[yangyanqing]

RE: your most recent comment - we should still use uatom in the documentation for the time being, when we make the switch then we can switch the docs

Our team wants to add multi-demon support to sdk. We are preparing the solution and will commit issue soon. Could you share your plan and solution ? @rigelrozanski

[yangyanqing]

Thanks for your review and so particular comment ! :) @rigelrozanski

[rigelrozanski]

@yangyanqing well if you want to keep the usage of atom in this PR then maybe we just hold off merging this PR and until CLI functionality for atom is enabled (CC @alexanderbez )

[yangyanqing]

@rigelrozanski All atom had been modify to uatom. What I want to modify in another PR is (aka redefine cobra.Command.Long in gaia).

[alexanderbez]

LGTM pending the changes to the modifications in x/ docs.

[alessio]

ACKed - provided that @alexanderbez's comment is addressed