-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a confirmation displaying the cost of transaction to the CLI #3653
Comments
Although I think you've got a point in asking to show users the gas price they are going to agree to pay for the tx, I have mixed feelings about turning this sort of interactive mode on by default, considering that we have a specific flag to only simulate the transaction and display an estimate of the gas price ( |
Thoughts @cosmos/cosmossdk ? |
I think it would also be okay to have this feature (which really only adds security) enabled by default so long as it could be easily turned off with |
I think confirming sends by default is fine, but we should have a |
👍 to the |
fret not @gamarin2, even though #3698 was merged, we can now simply add a new print statement in the prompt stating the converted fee. I stated it ties into #3510 now because we need this conversion functionality and denom mapping -- it can be simple for now (e.g. |
Summary
When you create a transaction, before you input your password you need to be prompted with the amount of Atoms this transaction will cost. Something like:
"This transaction will cost you 10 Atoms in transaction fees. Are you sure you want to proceed? Y\n"
Problem Definition
fees = gas * gas-prices
, a typo can end up in ten times more fees than expected.Proposal
For Admin Use
The text was updated successfully, but these errors were encountered: