Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Allow Simulation and Gen Only in REST Client #3467

Merged
merged 7 commits into from
Feb 2, 2019

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Feb 1, 2019

closes: #3423


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez changed the title WIP: Allow Auto Gas and Gen Only in REST Client WIP: Allow Simulation and Gen Only in REST Client Feb 1, 2019
@alexanderbez alexanderbez removed the request for review from ebuchman February 1, 2019 14:57
@codecov
Copy link

codecov bot commented Feb 1, 2019

Codecov Report

Merging #3467 into develop will increase coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop    #3467      +/-   ##
===========================================
+ Coverage    59.51%   59.52%   +<.01%     
===========================================
  Files          135      135              
  Lines         9981     9973       -8     
===========================================
- Hits          5940     5936       -4     
+ Misses        3669     3665       -4     
  Partials       372      372

@alexanderbez alexanderbez changed the title WIP: Allow Simulation and Gen Only in REST Client R4R: Allow Simulation and Gen Only in REST Client Feb 1, 2019
client/utils/errors.go Outdated Show resolved Hide resolved
Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small thing (promoting client/utils/errors.go to client). Nihil obstat from me otherwise

@alexanderbez
Copy link
Contributor Author

Yup -- I'll update @alessio

@jackzampolin jackzampolin merged commit 097a640 into develop Feb 2, 2019
@jackzampolin jackzampolin deleted the bez/3423-auto-gas-gen-only branch February 2, 2019 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic gas calculation doesn't work with generate_only
3 participants