R4R: Store Refactor 2 #3395
Merged
R4R: Store Refactor 2 #3395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mossid
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
mossid
force-pushed
the
joon/store-refactor-2
branch
from
751662a to
c005dc2
Compare
Codecov Report
@@ Coverage Diff @@
## develop #3395 +/- ##
===========================================
+ Coverage 52.97% 53.14% +0.17%
===========================================
Files 137 140 +3
Lines 10719 10202 -517
===========================================
- Hits 5678 5422 -256
+ Misses 4698 4446 -252
+ Partials 343 334 -9 |
|
Looks like this needs to be retargeted on develop. |
mossid
force-pushed
the
joon/store-refactor-2
branch
from
c005dc2 to
33ad665
Compare
alexanderbez
approved these changes
Feb 5, 2019
|
|
||
| type Error = sdk.Error | ||
|
|
||
| func ErrInternal(msg string) Error { |
There was a problem hiding this comment.
Why not just use the errors in the types/ package?
There was a problem hiding this comment.
I think it is, this is just a wrapper
cwgoes
approved these changes
Feb 5, 2019
|
|
||
| type Error = sdk.Error | ||
|
|
||
| func ErrInternal(msg string) Error { |
There was a problem hiding this comment.
I think it is, this is just a wrapper
|
Approved pending CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added entries in
PENDING.mdwith issue #rereviewed
Files changedin the github PR explorerAddresses: #2986
For Admin Use: