Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Parameter Change Proposal #2571

Closed

Conversation

mossid
Copy link
Contributor

@mossid mossid commented Oct 23, 2018

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer

Dependent on: #2497
Set base branch to #2497 for diffing easier


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@cwgoes
Copy link
Contributor

cwgoes commented Oct 25, 2018

@mossid Do we have a spec for parameter change proposals yet? I can't find anything in the governance spec.

Can we work on a spec first? I don't think we've finalized what we want to do here yet, so implementation is probably premature. If most of the mechanics are the same as for text proposals, it shouldn't take too long.

@mossid mossid mentioned this pull request Oct 26, 2018
5 tasks
@mossid mossid closed this Jan 5, 2019
@mossid mossid deleted the joon/parameter-change-proposal branch January 5, 2019 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants