Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Paramstore Followup #2491

Merged
merged 5 commits into from
Oct 15, 2018
Merged

R4R: Paramstore Followup #2491

merged 5 commits into from
Oct 15, 2018

Conversation

mossid
Copy link
Contributor

@mossid mossid commented Oct 13, 2018

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer

Closes: #2490

#2232 was merged so this branch contains some of the addressing to the comments there


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Oct 13, 2018

Codecov Report

Merging #2491 into develop will decrease coverage by 0.55%.
The diff coverage is 41.66%.

@@             Coverage Diff             @@
##           develop    #2491      +/-   ##
===========================================
- Coverage    61.93%   61.38%   -0.56%     
===========================================
  Files          150      153       +3     
  Lines         9476     9612     +136     
===========================================
+ Hits          5869     5900      +31     
- Misses        3199     3301     +102     
- Partials       408      411       +3

@mossid mossid changed the title WIP: Paramstore Followup R4R: Paramstore Followup Oct 13, 2018
@mossid mossid mentioned this pull request Oct 15, 2018
5 tasks
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, thanks @mossid 🍹

@cwgoes cwgoes merged commit 6164640 into develop Oct 15, 2018
@cwgoes cwgoes deleted the joon/2490-copy-godocs branch October 15, 2018 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants