fix(x/group): proper address rendering in error

[julienrbrt]

Description

Closes: #22414

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title, you can find examples of the prefixes below:
• confirmed ! in the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

• Bug Fixes
  • Improved error handling for unauthorized message signers, enhancing clarity in error messages.
  • Updated error reporting to provide a meaningful output even when address conversion fails.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes in this pull request focus on improving error handling within the ensureMsgAuthZ function in the proposal_executor.go file. The modifications enhance the clarity of error messages related to unauthorized message signers by converting the acct byte array to a string representation. If the conversion fails, a default message is used, ensuring that the error output remains meaningful. The overall logic of the doExecuteMsgs function remains unchanged.

Changes

File Path	Change Summary
x/group/keeper/proposal_executor.go	Improved error handling in ensureMsgAuthZ function by converting acct to a string for better readability in error messages.

Possibly related PRs

• fix(crypto/ledger): Improve error message when deriving paths #22116: This PR improves error messaging in the getPubKeyAddrSafe function, which is related to enhancing clarity in error reporting, similar to the changes made in the ensureMsgAuthZ function in the main PR.

Suggested labels

C:x/auth

Suggested reviewers

• facundomedica
• aaronc

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

@julienrbrt your pull request is missing a changelog!

[julienrbrt]

@julienrbrt your pull request is missing a changelog!

will be added in the 0.50 backport

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

x/group/keeper/proposal_executor.go (1)

74-77: Consider logging address conversion errors for debugging.

While the fallback handling for unmarshalable addresses is good, silently ignoring the conversion error might make debugging harder in production environments.

Consider adding error logging:

-				acctStr, _ := addressCodec.BytesToString(acct)
+				acctStr, err := addressCodec.BytesToString(acct)
+				if err != nil {
+					k.Logger(ctx).Debug("failed to convert address to string", "error", err, "raw_address", acct)
+					acctStr = "unmarshalable address"
+				}
-				if acctStr == "" {
-					acctStr = "unmarshalable address"
-				}

📜 Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between e0f644b and 354b9e7.

📒 Files selected for processing (1)

• x/group/keeper/proposal_executor.go (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

x/group/keeper/proposal_executor.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

🔇 Additional comments (1)

x/group/keeper/proposal_executor.go (1)

73-79: LGTM on the error message improvements!

The changes improve error message clarity by:

1. Properly handling address conversion failures
2. Providing meaningful fallback for unmarshalable addresses
3. Formatting the error message with human-readable addresses