Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update Twitter Links to X in Documentation #22408

Merged
merged 1 commit into from
Nov 4, 2024
Merged

docs: Update Twitter Links to X in Documentation #22408

merged 1 commit into from
Nov 4, 2024
+3 −3

Conversation

meetrick
Copy link
Contributor

@meetrick meetrick commented Nov 1, 2024 •
edited by coderabbitai bot
Loading

Updated outdated Twitter links to the new X.com domain in docs.

Description

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • Documentation
    • Updated acknowledgments section with new URLs for authors' Twitter handles.
    • Enhanced staking module documentation with detailed explanations of validator status transitions and roles.
    • Added CLI command examples for delegations, redelegations, and unbonding operations, reflecting the latest syntax and outputs.

@meetrick
docs: Update Twitter Links to X in Documentation
283cb81 
Updated outdated Twitter links to the new X.com domain in docs.

Signed-off-by: Hwangjae Lee <[email protected]>
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 1, 2024 •
edited
Loading

📝 Walkthrough

Walkthrough

The changes in this pull request involve updates to documentation files within the Cosmos SDK. Specifically, the acknowledgments section of a security document has updated URLs for authors' Twitter handles from twitter.com to x.com. Additionally, the staking module's README has been enhanced with new sections and clarifications, particularly regarding validator status transitions and updated CLI command examples for user interaction.

Changes

File Path Change Summary
docs/build/building-apps/04-security-part-1.md Updated Twitter URLs to x.com in the acknowledgments section.
x/staking/README.md Expanded documentation on validator status transitions, clarified roles, updated parameters, and added CLI command examples.

Possibly related PRs

Suggested reviewers

  • julienrbrt
  • tac0turtle
📜 Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 5b7fc8a and 283cb81.

📒 Files selected for processing (2)
  • docs/build/building-apps/04-security-part-1.md (1 hunks)
  • x/staking/README.md (2 hunks)
✅ Files skipped from review due to trivial changes (1)
  • docs/build/building-apps/04-security-part-1.md
🧰 Additional context used
📓 Path-based instructions (1)
x/staking/README.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

🔇 Additional comments (2)
x/staking/README.md (2)

2484-2484: LGTM: Twitter URL updated to X.com

The website URL has been correctly updated from Twitter to X.com to reflect the platform's rebranding.

2541-2541: LGTM: Twitter URL updated to X.com

The website URL has been correctly updated from Twitter to X.com to reflect the platform's rebranding.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@tac0turtle tac0turtle added this pull request to the merge queue Nov 4, 2024
Merged via the queue into cosmos:main with commit 838f155 Nov 4, 2024
72 of 80 checks passed
alpe added a commit that referenced this pull request Nov 6, 2024
@alpe
Merge branch 'main' into alex/sam/dec-type
711deef 
* main: (24 commits)
  build(deps): upgrade to [email protected] (#22436)
  docs: Update tendermint validators query pagination documentation (#22412)
  refactor(client/v2): offchain uses client/v2/factory (#22344)
  feat: wire new handlers to grpc (#22333)
  fix(x/group): proper address rendering in error (#22425)
  refactor(serevr/v2/cometbft): update `RegisterQueryHandlers` and GRPC queries (#22403)
  docs: update ADR 59 (#22423)
  build(deps): Bump github.com/fsnotify/fsnotify from 1.7.0 to 1.8.0 in /tools/cosmovisor (#22407)
  docs: Module account address documentation (#22289)
  feat(baseapp): add per message telemetry (#22175)
  docs: Update Twitter Links to X in Documentation (#22408)
  docs: redirect the remote generation page (#22404)
  refactor(serverv2): remove unused interface methods, honuor context  (#22394)
  fix(server/v2): return ErrHelp (#22399)
  feat(indexer): implement `schema.HasModuleCodec` interface in the `bank` module (#22349)
  refactor(math): refactor ApproxRoot for readality (#22263)
  docs: fix KWallet Handbook (#22395)
  feat(client/v2): broadcast logic (#22282)
  refactor(server/v2): eager config loading (#22267)
  test(system): check feePayers signature (#22389)
  ...
This was referenced Nov 11, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hieuvubk hieuvubk hieuvubk approved these changes

@akhilkumarpilli akhilkumarpilli akhilkumarpilli approved these changes

@tac0turtle tac0turtle tac0turtle approved these changes

@facundomedica facundomedica Awaiting requested review from facundomedica facundomedica is a code owner

@testinginprod testinginprod Awaiting requested review from testinginprod testinginprod is a code owner

@JulianToledano JulianToledano Awaiting requested review from JulianToledano JulianToledano is a code owner

@ziscky ziscky Awaiting requested review from ziscky ziscky is a code owner

Assignees

@facundomedica facundomedica

@tac0turtle tac0turtle

@hieuvubk hieuvubk

Labels
C:x/staking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@meetrick @tac0turtle @akhilkumarpilli @hieuvubk @facundomedica