feat(indexer): implement `schema.HasModuleCodec` interface in the `bank` module #22349

cool-develope · 2024-10-23T19:42:09Z

Description

ref: #20352

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

included the correct type prefix in the PR title, you can find examples of the prefixes below:
confirmed ! in the type prefix if API or client breaking change
targeted the correct branch (see PR Targeting)
provided a link to the relevant issue or specification
reviewed "Files changed" and left comments if necessary
included the necessary unit and integration tests
added a changelog entry to CHANGELOG.md
updated the relevant documentation or specification, including comments for documenting Go code
confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

confirmed the correct type prefix in the PR title
confirmed all author checklist items have been addressed
reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

New Features
- Introduced a new method for enhanced module codec handling, improving data decoding processes.
Improvements
- Enhanced clarity of key names in various collections, aiding in better data management.
Dependency Updates
- Updated module requirements for improved compatibility and functionality.

coderabbitai · 2024-10-23T19:42:16Z

Caution

Review failed

The head commit changed during the review from b7accc7 to 82a8d7e.

📝 Walkthrough

Walkthrough

The changes in this pull request primarily focus on enhancing the BaseViewKeeper implementation in the keeper/view.go file. A new method, ModuleCodec, is introduced to implement the schema.HasModuleCodec interface, facilitating the decoding of module KVPairUpdate. Additionally, modifications are made to the initialization of collections.Map and collections.IndexedMap instances, improving the clarity of key names and introducing NamedPairKeyCodec for the Balances map.

Changes

File	Change Summary
x/bank/keeper/view.go	- Added method `ModuleCodec` to `BaseViewKeeper` struct.
	- Updated initialization of `collections.Map` and `collections.IndexedMap` in `NewBaseViewKeeper`.
	- Introduced `NamedPairKeyCodec` for the `Balances` map.

Possibly related PRs

feat(server/v2): init the indexer in server/v2 #22218: The changes in this PR involve the introduction of new methods and configurations related to indexing, which may interact with the ModuleCodec functionality added in the main PR, particularly in how data is handled and decoded within the application.

Suggested labels

C:x/bank, C:schema

Suggested reviewers

tac0turtle
akhilkumarpilli
sontrinh16
julienrbrt
kocubinski

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2024-10-23T19:42:28Z

@cool-develope your pull request is missing a changelog!

octavio12345300 · 2024-10-24T07:01:00Z

😁

octavio12345300 · 2024-10-24T07:01:58Z

😁

julienrbrt

utACK

julienrbrt · 2024-10-24T08:38:27Z

Can you run go mod tidy?

aaronc

This is a good start. We will need to add HasSchemaCodec implementations for each of the codecs in follow ups. Right now they will probably end up with the default JSONB column type in Postgres which isn't ideal.

…nk` module (#22349) Co-authored-by: Facundo Medica <[email protected]> (cherry picked from commit 6b6e715) # Conflicts: # x/bank/go.mod # x/bank/keeper/view.go

…nk` module (backport #22349) (#22398) Co-authored-by: cool-developer <[email protected]> Co-authored-by: marbar3778 <[email protected]>

* main: (24 commits) build(deps): upgrade to [email protected] (#22436) docs: Update tendermint validators query pagination documentation (#22412) refactor(client/v2): offchain uses client/v2/factory (#22344) feat: wire new handlers to grpc (#22333) fix(x/group): proper address rendering in error (#22425) refactor(serevr/v2/cometbft): update `RegisterQueryHandlers` and GRPC queries (#22403) docs: update ADR 59 (#22423) build(deps): Bump github.com/fsnotify/fsnotify from 1.7.0 to 1.8.0 in /tools/cosmovisor (#22407) docs: Module account address documentation (#22289) feat(baseapp): add per message telemetry (#22175) docs: Update Twitter Links to X in Documentation (#22408) docs: redirect the remote generation page (#22404) refactor(serverv2): remove unused interface methods, honuor context (#22394) fix(server/v2): return ErrHelp (#22399) feat(indexer): implement `schema.HasModuleCodec` interface in the `bank` module (#22349) refactor(math): refactor ApproxRoot for readality (#22263) docs: fix KWallet Handbook (#22395) feat(client/v2): broadcast logic (#22282) refactor(server/v2): eager config loading (#22267) test(system): check feePayers signature (#22389) ...

module codec

1af5b0c

cool-develope requested review from julienrbrt, sontrinh16 and a team as code owners October 23, 2024 19:42

cool-develope assigned aaronc and julienrbrt Oct 23, 2024

github-prbot assigned sontrinh16 Oct 23, 2024

github-actions bot added the C:x/bank label Oct 23, 2024

julienrbrt added the backport/v0.52.x PR scheduled for inclusion in the v0.52's next stable release label Oct 23, 2024

sontrinh16 approved these changes Oct 23, 2024

View reviewed changes

octavio12345300 approved these changes Oct 24, 2024

View reviewed changes

julienrbrt approved these changes Oct 24, 2024

View reviewed changes

octavio12345300 approved these changes Oct 24, 2024

View reviewed changes

aaronc approved these changes Oct 24, 2024

View reviewed changes

octavio12345300 approved these changes Oct 24, 2024

View reviewed changes

facundomedica and others added 3 commits October 29, 2024 14:41

Merge branch 'main' into indexer/int_bank

b6b0baa

go mod tidy

b7accc7

Merge branch 'main' into indexer/int_bank

82a8d7e

cool-develope enabled auto-merge October 30, 2024 13:00

cool-develope added this pull request to the merge queue Oct 30, 2024

Merged via the queue into main with commit 6b6e715 Oct 30, 2024
72 of 73 checks passed

cool-develope deleted the indexer/int_bank branch October 30, 2024 13:19

mergify bot mentioned this pull request Oct 30, 2024

feat(indexer): implement schema.HasModuleCodec interface in the bank module (backport #22349) #22398

Merged

12 tasks

julienrbrt pushed a commit that referenced this pull request Nov 4, 2024

feat(indexer): implement schema.HasModuleCodec interface in the `ba…

878e306

…nk` module (backport #22349) (#22398) Co-authored-by: cool-developer <[email protected]> Co-authored-by: marbar3778 <[email protected]>

coderabbitai bot mentioned this pull request Nov 4, 2024

fix(indexer): the issues during simapp v1 integration #22413

Merged

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(indexer): implement `schema.HasModuleCodec` interface in the `bank` module #22349

feat(indexer): implement `schema.HasModuleCodec` interface in the `bank` module #22349

cool-develope commented Oct 23, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Oct 23, 2024 •

edited

Loading

Review failed

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

github-actions bot commented Oct 23, 2024

octavio12345300 commented Oct 24, 2024

octavio12345300 commented Oct 24, 2024

julienrbrt left a comment

julienrbrt commented Oct 24, 2024

aaronc left a comment

feat(indexer): implement schema.HasModuleCodec interface in the bank module #22349

feat(indexer): implement schema.HasModuleCodec interface in the bank module #22349

Conversation

cool-develope commented Oct 23, 2024 • edited by coderabbitai bot Loading

Description

Author Checklist

Reviewers Checklist

Summary by CodeRabbit

coderabbitai bot commented Oct 23, 2024 • edited Loading

Review failed

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

github-actions bot commented Oct 23, 2024

octavio12345300 commented Oct 24, 2024

octavio12345300 commented Oct 24, 2024

julienrbrt left a comment

Choose a reason for hiding this comment

julienrbrt commented Oct 24, 2024

aaronc left a comment

Choose a reason for hiding this comment

feat(indexer): implement `schema.HasModuleCodec` interface in the `bank` module #22349

feat(indexer): implement `schema.HasModuleCodec` interface in the `bank` module #22349

cool-develope commented Oct 23, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Oct 23, 2024 •

edited

Loading