-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add auto assign job #21939
ci: add auto assign job #21939
Conversation
Warning Rate limit exceeded@julienrbrt has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 12 minutes and 17 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 Walkthrough📝 Walkthrough📝 Walkthrough📝 Walkthrough📝 Walkthrough📝 Walkthrough📝 Walkthrough📝 WalkthroughWalkthroughA new GitHub Actions workflow named Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant GitHub
participant Workflow
User->>GitHub: Open or edit pull request
GitHub->>Workflow: Trigger workflow
Workflow->>GitHub: Checkout repository
Workflow->>GitHub: Retrieve requested reviewers
Workflow->>GitHub: Assign reviewers as assignees
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
.github/workflows/auto-assign-prs.yml (1)
1-30
: Overall, the workflow is well-designed with room for minor improvements.The "Auto Assign Reviewers" workflow is well-structured and achieves its intended purpose. It correctly triggers on relevant pull request events and uses appropriate actions for repository checkout and GitHub API interactions. The main area for improvement is in the script logic for assigning reviewers, where adding error handling and input validation would enhance robustness.
Consider adding a configuration file (e.g.,
.github/auto-assign-config.yml
) to make the workflow more flexible. This could allow for customization of assignee selection logic, such as team-based assignments or rotation schedules, without modifying the workflow file itself.
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
📒 Files selected for processing (1)
- .github/workflows/auto-assign-prs.yml (1 hunks)
🔇 Additional comments (3)
.github/workflows/auto-assign-prs.yml (3)
1-5
: LGTM: Workflow name and trigger are well-defined.The workflow name "Auto Assign Reviewers" accurately describes its purpose. The trigger events (pull request opened or edited) are appropriate for the intended functionality of assigning reviewers.
7-9
: LGTM: Job configuration is appropriate.The job name "assign-reviewers" is clear and descriptive. Using the latest Ubuntu runner (
ubuntu-latest
) is a good practice for staying up-to-date with security patches and features.
12-13
: LGTM: Repository checkout step is correctly implemented.The use of
actions/checkout@v4
is appropriate for accessing the repository contents. Using the latest stable version (v4) ensures you have the most up-to-date features and security fixes.
Cool, so it doesn't removes assignees if reviewers are removed, but I think it is fine. |
name: Auto Assign Reviewers | ||
|
||
on: | ||
pull_request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't work for external reviewers, but that's fine, I'll go assign reviewers manually like we do now.
This will already help daily.
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
in the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit