Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/gov): better gov genesis validation (backport #18707) #18711

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 12, 2023

This is an automatic backport of pull request #18707 done by Mergify.
Cherry-pick of 570ab64 has failed:

On branch mergify/bp/release/v0.50.x/pr-18707
Your branch is up to date with 'origin/release/v0.50.x'.

You are currently cherry-picking commit 570ab6476.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   x/gov/types/v1/genesis.go
	modified:   x/gov/types/v1/genesis_test.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   CHANGELOG.md
	deleted by us:   x/gov/go.mod

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

(cherry picked from commit 570ab64)

# Conflicts:
#	CHANGELOG.md
#	x/gov/go.mod
@mergify mergify bot requested a review from a team as a code owner December 12, 2023 21:03
@mergify mergify bot added the conflicts label Dec 12, 2023
@julienrbrt julienrbrt merged commit 14bc239 into release/v0.50.x Dec 13, 2023
39 of 45 checks passed
@julienrbrt julienrbrt deleted the mergify/bp/release/v0.50.x/pr-18707 branch December 13, 2023 06:51
@faddat faddat mentioned this pull request Nov 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants