R4R: Add slashing to governance for non-voting validators #1859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunnya97
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
sunnya97
force-pushed
the
sunny/gov_slashing
branch
from
a70dcc8
to
e6cb420
Compare
sunnya97
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #1859 +/- ##
===========================================
+ Coverage 63.5% 63.81% +0.31%
===========================================
Files 118 118
Lines 7006 7014 +8
===========================================
+ Hits 4449 4476 +27
+ Misses 2301 2284 -17
+ Partials 256 254 -2 |
cwgoes
approved these changes
Jul 28, 2018
x/gov/handler.go
Outdated
| @@ -137,11 +138,16 @@ func EndBlocker(ctx sdk.Context, keeper Keeper) (resTags sdk.Tags, nonVotingVals | |||
| } | |||
| keeper.SetProposal(ctx, activeProposal) | |||
|
|
|||
| for _, valAddr := range nonVotingVals { | |||
| val := keeper.ds.GetValidatorSet().Validator(ctx, valAddr) | |||
| keeper.ds.GetValidatorSet().Slash(ctx, val.GetPubKey(), ctx.BlockHeight(), val.GetPower().RoundInt64(), keeper.GetTallyingProcedure(ctx).GovernancePenalty) | |||
There was a problem hiding this comment.
This will slash delegators too - intentional presumably?
|
Thanks, - tests looked good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1854
docs/)PENDING.mdthat include links to the relevant issue or PR that most accurately describes the change.cmd/gaiaandexamples/For Admin Use: