Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: precise compiler assertions and cleanup module.go #17718

Merged
merged 4 commits into from
Sep 13, 2023

Conversation

julienrbrt
Copy link
Member

Description

Closes: #17715

Verifying that we do it properly in all our modules.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Sep 13, 2023
@julienrbrt julienrbrt changed the title docs: precise compiler assertions refactor: precise compiler assertions and cleanups module.go Sep 13, 2023
@julienrbrt julienrbrt marked this pull request as ready for review September 13, 2023 14:29
@julienrbrt julienrbrt requested a review from a team as a code owner September 13, 2023 14:29
@julienrbrt julienrbrt changed the title refactor: precise compiler assertions and cleanups module.go refactor: precise compiler assertions and cleanup module.go Sep 13, 2023
@github-prbot github-prbot requested review from a team, tac0turtle and testinginprod and removed request for a team September 13, 2023 14:42
@julienrbrt julienrbrt added this pull request to the merge queue Sep 13, 2023
Merged via the queue into main with commit 2154ce0 Sep 13, 2023
51 of 53 checks passed
@julienrbrt julienrbrt deleted the julien/upgrading-md branch September 13, 2023 16:19
julienrbrt added a commit that referenced this pull request Sep 13, 2023
@faddat faddat mentioned this pull request Nov 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Add compiler assertions to UPGRADING doc for v0.50
2 participants