Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(adr): Add Textual SpecVersion #15270

Merged
merged 6 commits into from
Mar 20, 2023
Merged

docs(adr): Add Textual SpecVersion #15270

merged 6 commits into from
Mar 20, 2023

Conversation

amaury1093
Copy link
Contributor

@amaury1093 amaury1093 commented Mar 6, 2023

Description

During a SIGN_MODE_TEXTUAL sync w/ @webmaster128 and @facundomedica, we discussed how to coordinate with client-side signing if we ever make updates to the ADR-050 spec.

We came up with a proposal to use a simple incremented integer to denote the spec version.

closes: #15291


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@amaury1093 amaury1093 marked this pull request as ready for review March 13, 2023 16:43
@amaury1093
Copy link
Contributor Author

amaury1093 commented Mar 13, 2023

I updated the initial version to 0

@amaury1093 amaury1093 enabled auto-merge (squash) March 20, 2023 15:29
@amaury1093 amaury1093 merged commit a8dcedd into main Mar 20, 2023
@amaury1093 amaury1093 deleted the am/textual-spec-version branch March 20, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

How to handle SIGN_MODE_TEXTUAL spec updates
3 participants