test(server/grpc): avoid using deprecated protoreflect function #15221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NewClient was deprecated in favor of NewClientAuto, in jhump/protoreflect v1.14.0. Dependabot recently updated us from v1.12 to v1.15, and the linter has been complaining about the use of the deprecated function.
facundomedica
approved these changes
Mar 1, 2023
Same, there are a few new features in v1.15. |
julienrbrt
reviewed
Mar 1, 2023
| // NOTE(fdymylja): we use grpcreflect because it solves imports too | ||
| // so that we can always assert that given a reflection server it is | ||
| // possible to fully query all the methods, without having any context | ||
| // on the proto registry | ||
| rc := grpcreflect.NewClient(ctx, stub) | ||
| rc := grpcreflect.NewClientAuto(ctx, s.conn) |
There was a problem hiding this comment.
Why not NewClientV1Alpha to keep the same behavior?
There was a problem hiding this comment.
The deprecation note says:
Use NewClientV1Alpha if you are intentionally pinning the v1alpha version of the reflection service.
I don't imagine we are intentionally pinning v1alpha here, are we?
julienrbrt
approved these changes
Mar 1, 2023
alexanderbez
approved these changes
Mar 1, 2023
julienrbrt
added
the
A:automerge
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NewClient was deprecated in favor of NewClientAuto, in jhump/protoreflect v1.14.0. Dependabot recently updated us from v1.12 to v1.15, and the linter has been complaining about the use of the deprecated function.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
provided a link to the relevant issue or specificationreviewed "Files changed" and left comments if necessaryReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...