Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow unknown fields in ParseTypedEvent #14995

Merged
merged 2 commits into from
Feb 10, 2023
Merged

fix: allow unknown fields in ParseTypedEvent #14995

merged 2 commits into from
Feb 10, 2023

Conversation

alexanderbez
Copy link
Contributor

Description

Closes: #14983

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@alexanderbez alexanderbez marked this pull request as ready for review February 10, 2023 14:56
@alexanderbez alexanderbez requested a review from a team as a code owner February 10, 2023 14:56
@alexanderbez alexanderbez enabled auto-merge (squash) February 10, 2023 15:03
julienrbrt
julienrbrt approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alexanderbez alexanderbez merged commit effbdb2 into main Feb 10, 2023
@alexanderbez alexanderbez deleted the bez/14983 branch February 10, 2023 16:04
@aaronc
Copy link
Member

aaronc commented Feb 10, 2023

Is this safe to backport?

@alexanderbez
Copy link
Contributor Author

Is this safe to backport?

I don't see why not? Depends on the callers of ParseTypedEvent.

@julienrbrt
Copy link
Member

julienrbrt commented Feb 13, 2023 •
edited
Loading

Is this safe to backport?

I don't see why not? Depends on the callers of ParseTypedEvent.

It should at least be in v0.47 imo given it's a fix.

@julienrbrt
Copy link
Member

@Mergifyio backport release/v0.47.x

@mergify mergify bot mentioned this pull request Feb 13, 2023
Merged
mergify bot pushed a commit that referenced this pull request Feb 13, 2023
@alexanderbez @mergify
fix: allow unknown fields in ParseTypedEvent (#14995)
4a91a2f 
(cherry picked from commit effbdb2)

# Conflicts:
#	CHANGELOG.md
@mergify
Copy link
Contributor

mergify bot commented Feb 13, 2023

backport release/v0.47.x

✅ Backports have been created

tac0turtle pushed a commit that referenced this pull request Feb 13, 2023
@mergify @alexanderbez @julienrbrt
fix: allow unknown fields in ParseTypedEvent (backport #14995) (#15005)
9774855 
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
@faddat faddat mentioned this pull request Mar 28, 2023
Closed
19 tasks
tsenart pushed a commit to meka-dev/cosmos-sdk that referenced this pull request Apr 12, 2023
@alexanderbez @tsenart
fix: allow unknown fields in ParseTypedEvent (cosmos#14995)
fe4e374
@0xstepit 0xstepit mentioned this pull request Jul 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@ryanchristo ryanchristo ryanchristo approved these changes

@JeancarloBarrios JeancarloBarrios JeancarloBarrios approved these changes

@kocubinski kocubinski Awaiting requested review from kocubinski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow unknown fields when parsing typed events
5 participants
@alexanderbez @aaronc @julienrbrt @JeancarloBarrios @ryanchristo