fix: add params migration #14992
Merged
fix: add params migration #14992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
added
the
backport/v0.47.x
julienrbrt
commented
Feb 10, 2023
UPGRADING.md
Outdated
|
|
||
| Cosmos SDK modules now store their parameters directly in its repective modules. In order to migrate these modules, you need to add the following when instantiating the params module in your `app.go`: | ||
|
|
||
| ```go |
There was a problem hiding this comment.
Maybe we could improve https://github.com/cosmos/cosmos-sdk/blob/3c53870/simapp/upgrades.go instead?
Trying something.
There was a problem hiding this comment.
Tried something in 5dff820, wdyt?
github-actions
bot
added
C:x/auth
C:x/crisis
C:x/distribution
julienrbrt
force-pushed
the
julien/upgrading-params
branch
from
5dff820
to
c18758d
Compare
github-actions
bot
added
C:x/auth
C:x/crisis
C:x/distribution
damiannolan
reviewed
Feb 10, 2023
julienrbrt
force-pushed
the
julien/upgrading-params
branch
from
4c58c8b
to
dc620a2
Compare
julienrbrt
changed the title
|
Thanks for all your work on this @julienrbrt, much appreciated! I think the last of the changes for x/auth migrations should fix the issue seen here: https://github.com/cosmos/ibc-go/actions/runs/4163041439/jobs/7202936700. Can rerun that workflow as soon as this hits |
9 tasks
tac0turtle
approved these changes
Feb 13, 2023
likhita-809
approved these changes
Feb 13, 2023
alexanderbez
approved these changes
Feb 13, 2023
| var ParamsKey = []byte{0x01} | ||
| var ParamsKey = []byte{0x00} |
There was a problem hiding this comment.
well this is concerning
There was a problem hiding this comment.
we need way better testing on migrations. This is too close to a release
mergify bot
pushed a commit
that referenced
this pull request
Feb 13, 2023
(cherry picked from commit 0f99829) # Conflicts: # UPGRADING.md # simapp/app.go # simapp/upgrades.go
5 tasks
julienrbrt
added a commit
that referenced
this pull request
Feb 13, 2023
Co-authored-by: Julien Robert <[email protected]>
19 tasks
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cc @alexanderbez
Now migration from simapp 46 to simapp 47 works.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change