chore: upstream error on empty version #13355

tac0turtle · 2022-09-21T11:37:18Z

Description

Users were getting empty results when the version was not present in the tree, this returns an error instead

shoutout to @mattverse for the fix on the osmosis fork

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
confirmed all author checklist items have been addressed
reviewed state machine logic
reviewed API design and naming
reviewed documentation is accurate
reviewed tests and test coverage
manually tested (if applicable)

tac0turtle · 2022-09-21T12:40:54Z

store/rootmulti/snapshot_test.go

@@ -128,7 +128,7 @@ func TestMultistoreSnapshot_Checksum(t *testing.T) {
 			"aa048b4ee0f484965d7b3b06822cf0772cdcaad02f3b1b9055e69f2cb365ef3c",
 			"7921eaa3ed4921341e504d9308a9877986a879fe216a099c86e8db66fcba4c63",
 			"a4a864e6c02c9fca5837ec80dc84f650b25276ed7e4820cf7516ced9f9901b86",
-			"ca2879ac6e7205d257440131ba7e72bef784cd61642e32b847729e543c1928b9",
+			"8ca5b957e36fa13e704c31494649b2a74305148d70d70f0f26dee066b615c1d0",


digging through the code and finding it hard to see why this changed. I thought because maybe {} was being included in the checksum but doesn't seem so

No idea why this change caused this test to fail. Maybe just update the test assertion?

I suspect you are using go 1.19 right? https://github.com/cosmos/cosmos-sdk/actions/runs/3097837960/jobs/5015002343.

We still need to figure out why this change in go 1.19.

codecov · 2022-09-21T15:24:38Z

Codecov Report

Merging #13355 (105c91e) into main (a2118af) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #13355      +/-   ##
==========================================
- Coverage   54.81%   54.77%   -0.04%     
==========================================
  Files         652      652              
  Lines       55847    55847              
==========================================
- Hits        30612    30590      -22     
- Misses      22759    22782      +23     
+ Partials     2476     2475       -1

Impacted Files	Coverage Δ
store/iavl/store.go	`56.95% <100.00%> (ø)`
x/distribution/simulation/operations.go	`80.64% <0.00%> (-9.68%)`	⬇️
x/staking/simulation/operations.go	`74.54% <0.00%> (-1.38%)`	⬇️
x/group/keeper/keeper.go	`56.25% <0.00%> (-0.40%)`	⬇️
store/rootmulti/store.go	`73.61% <0.00%> (+0.43%)`	⬆️

julienrbrt · 2023-04-06T07:10:02Z

@Mergifyio backport release/v0.46.x

mergify · 2023-04-06T07:10:05Z

backport release/v0.46.x

✅ Backports have been created

#15717 chore: upstream error on empty version (backport #13355) has been created for branch release/v0.46.x

* upstream error on empty version * fix tests * revert change (cherry picked from commit 107ffee)

Co-authored-by: Marko <[email protected]> Co-authored-by: Julien Robert <[email protected]>

* fix: create snapshot dir for rocksdb backend (backport cosmos#15054) (cosmos#15065) Co-authored-by: yihuang <[email protected]> * chore: Add check for uneven stores' height (backport cosmos#14410) (cosmos#15115) Co-authored-by: khanh-notional <[email protected]> Co-authored-by: marbar3778 <[email protected]> * refactor!: remove store v2alpha1 (cosmos#15152) * build: use cometbft in v0.46 (cosmos#15090) * chore: bump cometbft to v0.34.27 final (cosmos#15206) * fix: Change proposer address cast for `sdk_block` conversion (backport cosmos#15243) (cosmos#15245) Co-authored-by: Maksym Hontar <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix: revert double close fix (cosmos#15255) * chore: prepare v0.46.11 release (cosmos#15259) * feat: add extend cb to avoid unmarshal state twice for sim test (backport: cosmos#15305) (cosmos#15321) * feat: add extend cb with genesisState for sim test (backport: cosmos#15305) (cosmos#15349) * fix: add extra check in vesting (backport cosmos#15373) (cosmos#15383) Co-authored-by: Julien Robert <[email protected]> * docs: update cosmwasm link (cosmos#15441) * fix: remove extra `;` in service.proto (cosmos#15443) * fix: flaky group genesis sim (backport cosmos#15447) (cosmos#15461) Co-authored-by: Robert Zaremba <[email protected]> * feat: add delegator to withdraw address (backport cosmos#15462) (cosmos#15473) Co-authored-by: Marko <[email protected]> * docs: improve proto vesting docs about time attributes (backport cosmos#15474) (cosmos#15481) Co-authored-by: Julien Robert <[email protected]> * feat: add query `groups` in `x/group` (backport cosmos#14879) (cosmos#15476) Co-authored-by: atheeshp <[email protected]> Co-authored-by: marbar3778 <[email protected]> * fix: Makefile rocksdb (backport cosmos#15422) (cosmos#15525) Co-authored-by: Robert Zaremba <[email protected]> * fix(x/gov): Return ErrInvalidProposalContent in SubmitProposal when legacy handler returns an error. (backport cosmos#13051) (cosmos#15667) Co-authored-by: Daniel Wedul <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]> * fix: remove unnecessary cms typecasting (backport cosmos#14054) (cosmos#15669) Co-authored-by: Javier Su <[email protected]> Co-authored-by: Julien Robert <[email protected]> * chore: prepare v0.46.12 release notes (cosmos#15685) * fix: upstream error on empty version (backport cosmos#13355) (cosmos#15717) Co-authored-by: Marko <[email protected]> Co-authored-by: Julien Robert <[email protected]> * feat: More flexibility for `CacheMultiStoreWithVersion` (backport cosmos#15683) (cosmos#15775) Co-authored-by: khanh-notional <[email protected]> Co-authored-by: Julien Robert <[email protected]> * feat: add moduleStateCb to allow access moduleState in sim test (backport cosmos#15903) (cosmos#15925) Co-authored-by: mmsqe <[email protected]> Co-authored-by: Julien Robert <[email protected]> * build(deps): bump cometbft to v0.34.28 (cosmos#15973) * chore(gov): improve proposal conversion error message (backport cosmos#15979) (cosmos#15981) Co-authored-by: Julien Robert <[email protected]> Co-authored-by: marbar3778 <[email protected]> * feat!: bootstrap comet cmd for local state sync (backport cosmos#16061) (cosmos#16080) Co-authored-by: Marko <[email protected]> * chore(auth/vesting): fix typo in `create-period-vesting-account` cmd example (backport cosmos#16085) (cosmos#16087) Co-authored-by: Julien Robert <[email protected]> * feat: add local snapshots management commands (backport cosmos#16067) (cosmos#16103) Co-authored-by: yihuang <[email protected]> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix: snapshot commands panic if snapshot don't exists (backport cosmos#16138) (cosmos#16140) Co-authored-by: yihuang <[email protected]> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: Julien Robert <[email protected]> * feat: add Close method for resource cleanup in graceful shutdown (backport cosmos#16193) (cosmos#16205) Co-authored-by: yihuang <[email protected]> Co-authored-by: Julien Robert <[email protected]> * feat: save restored snapshot locally (backport cosmos#16060) (cosmos#16262) Co-authored-by: yihuang <[email protected]> Co-authored-by: marbar3778 <[email protected]> * chore: update sidebar v0.46 (cosmos#16304) * chore: add baseapp circuit breaker setter (cosmos#16289) Co-authored-by: Julien Robert <[email protected]> * fix: allow any address in `ValidatePromptAddress` (backport cosmos#16312) (cosmos#16314) Co-authored-by: Julien Robert <[email protected]> * feat(group): add group event tally result (backport cosmos#16191) (cosmos#16306) Co-authored-by: Jeancarlo Barrios <[email protected]> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix: Revert "fix(x/gov): Return ErrInvalidProposalContent in SubmitProposal when legacy handler returns an error. (backport cosmos#13051) (cosmos#15667)" (cosmos#16331) * chore: prepare v0.46.13 (cosmos#16249) * chore: small snapshot commands & docs improvement (backport cosmos#16404) (cosmos#16409) Co-authored-by: Julien Robert <[email protected]> * Add the quarantine and sanction stores to the import-export sim test. * refactor: avoid breaking change due to cosmos#16415 included in v0.50 (backport cosmos#16430) (cosmos#16432) Co-authored-by: Julien Robert <[email protected]> Co-authored-by: Facundo Medica <[email protected]> * chore: prepare v0.46.13 (2/2) (cosmos#16443) * fix: patch barberry (cosmos#16466) * Better gov prop error handling. * Fix the group sims random genesis so it can't pick the same account twice for the group policies since that address is the primary key for the table. Also, output the genesis state after it's randomized just like all the other modules do. * Add changelog entries. * Regen the swagger docs. --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: yihuang <[email protected]> Co-authored-by: khanh-notional <[email protected]> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: Julien Robert <[email protected]> Co-authored-by: Maksym Hontar <[email protected]> Co-authored-by: mmsqe <[email protected]> Co-authored-by: Robert Zaremba <[email protected]> Co-authored-by: atheeshp <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: Javier Su <[email protected]> Co-authored-by: mmsqe <[email protected]> Co-authored-by: Jeancarlo Barrios <[email protected]> Co-authored-by: Facundo Medica <[email protected]>

* fix: create snapshot dir for rocksdb backend (backport cosmos#15054) (cosmos#15065) * chore: Add check for uneven stores' height (backport cosmos#14410) (cosmos#15115) * refactor!: remove store v2alpha1 (cosmos#15152) * build: use cometbft in v0.46 (cosmos#15090) * chore: bump cometbft to v0.34.27 final (cosmos#15206) * fix: Change proposer address cast for `sdk_block` conversion (backport cosmos#15243) (cosmos#15245) * fix: revert double close fix (cosmos#15255) * chore: prepare v0.46.11 release (cosmos#15259) * feat: add extend cb to avoid unmarshal state twice for sim test (backport: cosmos#15305) (cosmos#15321) * feat: add extend cb with genesisState for sim test (backport: cosmos#15305) (cosmos#15349) * fix: add extra check in vesting (backport cosmos#15373) (cosmos#15383) * docs: update cosmwasm link (cosmos#15441) * fix: remove extra `;` in service.proto (cosmos#15443) * fix: flaky group genesis sim (backport cosmos#15447) (cosmos#15461) * feat: add delegator to withdraw address (backport cosmos#15462) (cosmos#15473) * docs: improve proto vesting docs about time attributes (backport cosmos#15474) (cosmos#15481) * feat: add query `groups` in `x/group` (backport cosmos#14879) (cosmos#15476) * fix: Makefile rocksdb (backport cosmos#15422) (cosmos#15525) * fix(x/gov): Return ErrInvalidProposalContent in SubmitProposal when legacy handler returns an error. (backport cosmos#13051) (cosmos#15667) * fix: remove unnecessary cms typecasting (backport cosmos#14054) (cosmos#15669) * chore: prepare v0.46.12 release notes (cosmos#15685) * fix: upstream error on empty version (backport cosmos#13355) (cosmos#15717) * feat: More flexibility for `CacheMultiStoreWithVersion` (backport cosmos#15683) (cosmos#15775) * feat: add moduleStateCb to allow access moduleState in sim test (backport cosmos#15903) (cosmos#15925) * build(deps): bump cometbft to v0.34.28 (cosmos#15973) * chore(gov): improve proposal conversion error message (backport cosmos#15979) (cosmos#15981) * feat!: bootstrap comet cmd for local state sync (backport cosmos#16061) (cosmos#16080) * chore(auth/vesting): fix typo in `create-period-vesting-account` cmd example (backport cosmos#16085) (cosmos#16087) * feat: add local snapshots management commands (backport cosmos#16067) (cosmos#16103) * fix: snapshot commands panic if snapshot don't exists (backport cosmos#16138) (cosmos#16140) * feat: add Close method for resource cleanup in graceful shutdown (backport cosmos#16193) (cosmos#16205) * feat: save restored snapshot locally (backport cosmos#16060) (cosmos#16262) * chore: update sidebar v0.46 (cosmos#16304) * chore: add baseapp circuit breaker setter (cosmos#16289) * fix: allow any address in `ValidatePromptAddress` (backport cosmos#16312) (cosmos#16314) * feat(group): add group event tally result (backport cosmos#16191) (cosmos#16306) * fix: Revert "fix(x/gov): Return ErrInvalidProposalContent in SubmitProposal when legacy handler returns an error. (backport cosmos#13051) (cosmos#15667)" (cosmos#16331) * chore: prepare v0.46.13 (cosmos#16249) * chore: small snapshot commands & docs improvement (backport cosmos#16404) (cosmos#16409) * Add the quarantine and sanction stores to the import-export sim test. * refactor: avoid breaking change due to cosmos#16415 included in v0.50 (backport cosmos#16430) (cosmos#16432) * chore: prepare v0.46.13 (2/2) (cosmos#16443) * fix: patch barberry (cosmos#16466) * Better gov prop error handling. * Fix the group sims random genesis so it can't pick the same account twice for the group policies since that address is the primary key for the table. Also, output the genesis state after it's randomized just like all the other modules do. * Add changelog entries. * Regen the swagger docs. --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: yihuang <[email protected]> Co-authored-by: khanh-notional <[email protected]> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: Julien Robert <[email protected]> Co-authored-by: Maksym Hontar <[email protected]> Co-authored-by: mmsqe <[email protected]> Co-authored-by: Robert Zaremba <[email protected]> Co-authored-by: atheeshp <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: Javier Su <[email protected]> Co-authored-by: mmsqe <[email protected]> Co-authored-by: Jeancarlo Barrios <[email protected]> Co-authored-by: Facundo Medica <[email protected]>

…15717) Co-authored-by: Marko <[email protected]> Co-authored-by: Julien Robert <[email protected]>

upstream error on empty version

464c429

github-actions bot added the C:Store label Sep 21, 2022

fix tests

fa123d5

tac0turtle marked this pull request as ready for review September 21, 2022 12:39

tac0turtle requested a review from a team as a code owner September 21, 2022 12:39

tac0turtle commented Sep 21, 2022

View reviewed changes

alexanderbez approved these changes Sep 21, 2022

View reviewed changes

alexanderbez enabled auto-merge (squash) September 21, 2022 14:20

tac0turtle disabled auto-merge September 21, 2022 14:27

revert change

105c91e

julienrbrt approved these changes Sep 21, 2022

View reviewed changes

julienrbrt merged commit 107ffee into main Sep 21, 2022

julienrbrt deleted the marko/return_error_emptyversion branch September 21, 2022 16:31

facundomedica mentioned this pull request Nov 4, 2022

Querying /cosmos/bank/v1beta1/supply for a past block height returns a panic #13767

Closed

ttl33 mentioned this pull request Dec 29, 2022

Accessing the state at height == 0 fails and throws errors #14446

Closed

rkollar mentioned this pull request Jan 1, 2023

Accessing store gives nil pointer panic #14029

Closed

ttl33 mentioned this pull request Jan 14, 2023

RPC requests during node startup trigger error #14620

Closed

AaronKutch mentioned this pull request Apr 5, 2023

Merge the *-ics variations into the mainline Cosmos SDK cosmos/interchain-security#828

Closed

mergify bot pushed a commit that referenced this pull request Apr 6, 2023

chore: upstream error on empty version (#13355)

31f0515

* upstream error on empty version * fix tests * revert change (cherry picked from commit 107ffee)

mergify bot mentioned this pull request Apr 6, 2023

fix: upstream error on empty version (backport #13355) #15717

Merged

tac0turtle added a commit that referenced this pull request Apr 6, 2023

fix: upstream error on empty version (backport #13355) (#15717)

1a47cb2

Co-authored-by: Marko <[email protected]> Co-authored-by: Julien Robert <[email protected]>

faddat mentioned this pull request Jun 8, 2023

barberry realiotech/cosmos-sdk#30

Merged

JeancarloBarrios pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Sep 28, 2024

fix: upstream error on empty version (backport cosmos#13355) (cosmos#…

48fd5f9

…15717) Co-authored-by: Marko <[email protected]> Co-authored-by: Julien Robert <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: upstream error on empty version #13355

chore: upstream error on empty version #13355

tac0turtle commented Sep 21, 2022 •

edited

Loading

tac0turtle Sep 21, 2022

alexanderbez Sep 21, 2022

julienrbrt Sep 21, 2022 •

edited

Loading

codecov bot commented Sep 21, 2022

julienrbrt commented Apr 6, 2023

mergify bot commented Apr 6, 2023 •

edited

Loading

chore: upstream error on empty version #13355

chore: upstream error on empty version #13355

Conversation

tac0turtle commented Sep 21, 2022 • edited Loading

Description

Author Checklist

Reviewers Checklist

tac0turtle Sep 21, 2022

Choose a reason for hiding this comment

alexanderbez Sep 21, 2022

Choose a reason for hiding this comment

julienrbrt Sep 21, 2022 • edited Loading

Choose a reason for hiding this comment

codecov bot commented Sep 21, 2022

Codecov Report

julienrbrt commented Apr 6, 2023

mergify bot commented Apr 6, 2023 • edited Loading

✅ Backports have been created

tac0turtle commented Sep 21, 2022 •

edited

Loading

julienrbrt Sep 21, 2022 •

edited

Loading

mergify bot commented Apr 6, 2023 •

edited

Loading