From 577e978facd48d9b4d36d57ea8ab7a068e451df6 Mon Sep 17 00:00:00 2001 From: atheesh Date: Wed, 18 May 2022 15:00:29 +0530 Subject: [PATCH 1/6] fix: cli `grantee-grants`, `granter-grants` cmds --- x/feegrant/client/cli/query.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/x/feegrant/client/cli/query.go b/x/feegrant/client/cli/query.go index 66e26b328e18..46565e592f12 100644 --- a/x/feegrant/client/cli/query.go +++ b/x/feegrant/client/cli/query.go @@ -84,7 +84,7 @@ $ %s query feegrant grant [granter] [grantee] // GetCmdQueryFeeGrantsByGrantee returns cmd to query for all grants for a grantee. func GetCmdQueryFeeGrantsByGrantee() *cobra.Command { cmd := &cobra.Command{ - Use: "grants [grantee]", + Use: "grantee-grants [grantee]", Args: cobra.ExactArgs(1), Short: "Query all grants of a grantee", Long: strings.TrimSpace( @@ -133,7 +133,7 @@ $ %s query feegrant grants [grantee] // GetCmdQueryFeeGrantsByGranter returns cmd to query for all grants by a granter. func GetCmdQueryFeeGrantsByGranter() *cobra.Command { cmd := &cobra.Command{ - Use: "grants [granter]", + Use: "granter-grants [granter]", Args: cobra.ExactArgs(1), Short: "Query all grants by a granter", Long: strings.TrimSpace( From 50fe15cd2e535e0594826f2cc9e4796f0793a036 Mon Sep 17 00:00:00 2001 From: atheesh Date: Thu, 19 May 2022 11:00:06 +0530 Subject: [PATCH 2/6] review changes --- x/authz/client/cli/query.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/x/authz/client/cli/query.go b/x/authz/client/cli/query.go index dfc997c445e4..178b5ddf8a56 100644 --- a/x/authz/client/cli/query.go +++ b/x/authz/client/cli/query.go @@ -96,13 +96,13 @@ $ %s query %s grants cosmos1skjw.. cosmos1skjwj.. %s func GetQueryGranterGrants() *cobra.Command { cmd := &cobra.Command{ - Use: "granter-grants [granter-addr]", + Use: "grants-by-granter [granter-addr]", Args: cobra.ExactArgs(1), Short: "query authorization grants granted by granter", Long: strings.TrimSpace( fmt.Sprintf(`Query authorization grants granted by granter. Examples: -$ %s q %s granter-grants cosmos1skj.. +$ %s q %s grants-by-granter cosmos1skj.. `, version.AppName, authz.ModuleName), ), @@ -144,13 +144,13 @@ $ %s q %s granter-grants cosmos1skj.. func GetQueryGranteeGrants() *cobra.Command { cmd := &cobra.Command{ - Use: "grantee-grants [grantee-addr]", + Use: "grants-by-grantee [grantee-addr]", Args: cobra.ExactArgs(1), Short: "query authorization grants granted to a grantee", Long: strings.TrimSpace( fmt.Sprintf(`Query authorization grants granted to a grantee. Examples: -$ %s q %s grantee-grants cosmos1skj.. +$ %s q %s grants-by-grantee cosmos1skj.. `, version.AppName, authz.ModuleName), ), From 99de8d7d060696204fc6fef24dc01602eb0f67a1 Mon Sep 17 00:00:00 2001 From: atheesh Date: Thu, 19 May 2022 11:20:01 +0530 Subject: [PATCH 3/6] update changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index b565059d307e..76f4796000aa 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -276,6 +276,7 @@ Ref: https://keepachangelog.com/en/1.0.0/ * (x/feegrant) [\#11813](https://github.com/cosmos/cosmos-sdk/pull/11813) Fix pagination total count in `AllowancesByGranter` query. * (simapp) [\#11855](https://github.com/cosmos/cosmos-sdk/pull/11855) Use `sdkmath.Int` instead of `int64` for `SimulationState.InitialStake`. * (x/capability) [\#11737](https://github.com/cosmos/cosmos-sdk/pull/11737) Use a fixed length encoding of `Capability` pointer for `FwdCapabilityKey` +* (x/feegrant) [\#11983](https://github.com/cosmos/cosmos-sdk/pull/11983) fix `grants-by-grantee`, `grants-by-granter` cmds ### State Machine Breaking From 49cd6967d94c3e8107cd8fadede37fde0d0bc71e Mon Sep 17 00:00:00 2001 From: atheesh Date: Thu, 19 May 2022 11:47:27 +0530 Subject: [PATCH 4/6] review changes --- x/feegrant/client/cli/query.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/x/feegrant/client/cli/query.go b/x/feegrant/client/cli/query.go index 46565e592f12..8493c885b271 100644 --- a/x/feegrant/client/cli/query.go +++ b/x/feegrant/client/cli/query.go @@ -84,14 +84,14 @@ $ %s query feegrant grant [granter] [grantee] // GetCmdQueryFeeGrantsByGrantee returns cmd to query for all grants for a grantee. func GetCmdQueryFeeGrantsByGrantee() *cobra.Command { cmd := &cobra.Command{ - Use: "grantee-grants [grantee]", + Use: "grants-by-grantee [grantee]", Args: cobra.ExactArgs(1), Short: "Query all grants of a grantee", Long: strings.TrimSpace( fmt.Sprintf(`Queries all the grants for a grantee address. Example: -$ %s query feegrant grants [grantee] +$ %s query feegrant grants-by-grantee [grantee] `, version.AppName), ), RunE: func(cmd *cobra.Command, args []string) error { @@ -133,14 +133,14 @@ $ %s query feegrant grants [grantee] // GetCmdQueryFeeGrantsByGranter returns cmd to query for all grants by a granter. func GetCmdQueryFeeGrantsByGranter() *cobra.Command { cmd := &cobra.Command{ - Use: "granter-grants [granter]", + Use: "grants-by-granter [granter]", Args: cobra.ExactArgs(1), Short: "Query all grants by a granter", Long: strings.TrimSpace( fmt.Sprintf(`Queries all the grants issued for a granter address. Example: -$ %s query feegrant grants [granter] +$ %s query feegrant grants-by-granter [granter] `, version.AppName), ), RunE: func(cmd *cobra.Command, args []string) error { From d81cd2bfe91a6e346dbe05fb3f136311b57a30d6 Mon Sep 17 00:00:00 2001 From: atheeshp <59333759+atheeshp@users.noreply.github.com> Date: Thu, 19 May 2022 11:55:05 +0530 Subject: [PATCH 5/6] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4f3827996d5e..21ab6bac590c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -277,7 +277,7 @@ Ref: https://keepachangelog.com/en/1.0.0/ * (x/feegrant) [\#11813](https://github.com/cosmos/cosmos-sdk/pull/11813) Fix pagination total count in `AllowancesByGranter` query. * (simapp) [\#11855](https://github.com/cosmos/cosmos-sdk/pull/11855) Use `sdkmath.Int` instead of `int64` for `SimulationState.InitialStake`. * (x/capability) [\#11737](https://github.com/cosmos/cosmos-sdk/pull/11737) Use a fixed length encoding of `Capability` pointer for `FwdCapabilityKey` -* (x/feegrant) [\#11983](https://github.com/cosmos/cosmos-sdk/pull/11983) fix `grants-by-grantee`, `grants-by-granter` cmds +* [\#11983](https://github.com/cosmos/cosmos-sdk/pull/11983) (x/feegrant, x/authz) fix `grants-by-grantee`, `grants-by-granter` cmds ### State Machine Breaking From 80cae8001e76c10d4eb65209a2fec2f673c52970 Mon Sep 17 00:00:00 2001 From: Aleksandr Bezobchuk Date: Thu, 19 May 2022 09:45:22 -0400 Subject: [PATCH 6/6] Update CHANGELOG.md Co-authored-by: Julien Robert --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 21ab6bac590c..b9849e0ee7e8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -277,7 +277,7 @@ Ref: https://keepachangelog.com/en/1.0.0/ * (x/feegrant) [\#11813](https://github.com/cosmos/cosmos-sdk/pull/11813) Fix pagination total count in `AllowancesByGranter` query. * (simapp) [\#11855](https://github.com/cosmos/cosmos-sdk/pull/11855) Use `sdkmath.Int` instead of `int64` for `SimulationState.InitialStake`. * (x/capability) [\#11737](https://github.com/cosmos/cosmos-sdk/pull/11737) Use a fixed length encoding of `Capability` pointer for `FwdCapabilityKey` -* [\#11983](https://github.com/cosmos/cosmos-sdk/pull/11983) (x/feegrant, x/authz) fix `grants-by-grantee`, `grants-by-granter` cmds +* [\#11983](https://github.com/cosmos/cosmos-sdk/pull/11983) (x/feegrant, x/authz) rename grants query commands to `grants-by-grantee`, `grants-by-granter` cmds. ### State Machine Breaking