Feature/remove client from basecoin

CHANGELOG.md

@@ -1,5 +1,32 @@
 # Changelog
 
+## 0.6.0 (???)
+
+Make the basecli command the only way to use client-side, to enforce best
+security practices. Lots of enhancements to get it up to production quality.
+
+BREAKING CHANGES:
+- basecli
+  - `basecli proof state get` -> `basecli query key`
+  - `basecli proof tx get` -> `basecli query tx`
+  - `basecli proof state get --app=account` -> `basecli query account`
+  - use `--chain-id` not `--chainid` for consistency
+  - update to use `--trace` not `--debug` for stack traces on errors
+  - complete overhaul on how tx and query subcommands are added. (see counter or trackomatron for examples)
+  - no longer supports counter app (see new countercli)
+- basecoin
+  - removed all client side functionality from it (use basecli now for proofs)
+
+ENHANCEMENTS:
+- intergrates tendermint 0.10.0 (not the rc-2, but the real thing)
+- commands return error code (1) on failure for easier script testing
+- add `reset_all` to basecli, and never delete keys on `init`
+- new shutil based unit tests, with better coverage of the cli actions
+
+BUG FIXES:
+- no longer panics on missing app_options in genesis (thanks, anton)
+
+
 ## 0.5.2 (June 2, 2017)
 
 BUG FIXES:

Makefile

@@ -1,9 +1,8 @@
-GOTOOLS = \
-					github.com/mitchellh/gox \
-					github.com/Masterminds/glide
+GOTOOLS =	github.com/mitchellh/gox \
+			github.com/Masterminds/glide
 PACKAGES=$(shell go list ./... | grep -v '/vendor/')
 
-all: get_vendor_deps test install
+all: get_vendor_deps install test
 
 build:
 	go build ./cmd/...
@@ -15,36 +14,34 @@ dist:
 	@bash scripts/dist.sh
 	@bash scripts/publish.sh
 
-clitest/shunit2:
-	wget "https://raw.githubusercontent.com/kward/shunit2/master/source/2.1/src/shunit2" \
-		-q -O clitest/shunit2
-
-test_cli: clitest/shunit2
-	# sudo apt-get install jq
-	@./clitest/basictx.sh
-	# @./clitest/ibc.sh
+test: test_unit test_cli
 
-test:
+test_unit:
 	go test $(PACKAGES)
 	#go run tests/tendermint/*.go
 
-# get_deps:
-# 	go get -d ./...
-
-# update_deps:
-# 	go get -d -u ./...
+test_cli: tests/cli/shunit2
+	# sudo apt-get install jq
+	@./tests/cli/basictx.sh
+	@./tests/cli/counter.sh
+	@./tests/cli/ibc.sh
 
 get_vendor_deps: tools
 	glide install
 
 build-docker:
-	docker run -it --rm -v "$(PWD):/go/src/github.com/tendermint/basecoin" -w "/go/src/github.com/tendermint/basecoin" -e "CGO_ENABLED=0" golang:alpine go build ./cmd/basecoin
+	docker run -it --rm -v "$(PWD):/go/src/github.com/tendermint/basecoin" -w \
+		"/go/src/github.com/tendermint/basecoin" -e "CGO_ENABLED=0" golang:alpine go build ./cmd/basecoin
 	docker build -t "tendermint/basecoin" .
 
+tests/cli/shunit2:
+	wget "https://raw.githubusercontent.com/kward/shunit2/master/source/2.1/src/shunit2" \
+		-q -O tests/cli/shunit2
+
 tools:
 	go get -u -v $(GOTOOLS)
 
 clean:
 	@rm -f ./basecoin
 
-.PHONY: all build install test get_deps update_deps get_vendor_deps build-docker clean
+.PHONY: all build install test test_cli test_unit get_vendor_deps build-docker clean

circle.yml

@@ -19,9 +19,8 @@ dependencies:
 
 test:
   override:
-    - "cd $REPO && glide install && go install ./cmd/basecoin"
+    - "cd $REPO && glide install && go install ./cmd/..."
     - ls $GOPATH/bin
     - "cd $REPO && make test"
-    - "cd $REPO/demo && bash start.sh"