From 117767139d7b5e138afe4ed121f901f494740c86 Mon Sep 17 00:00:00 2001 From: marbar3778 Date: Mon, 31 Jan 2022 10:38:28 +0000 Subject: [PATCH 01/28] use buf ci --- .github/workflows/proto.yml | 43 ++++++++++++++++++++++++------------- 1 file changed, 28 insertions(+), 15 deletions(-) diff --git a/.github/workflows/proto.yml b/.github/workflows/proto.yml index 1ddbf009764a..ea622e68f086 100644 --- a/.github/workflows/proto.yml +++ b/.github/workflows/proto.yml @@ -3,28 +3,41 @@ name: Protobuf # This workflow is only run when a .proto file has been changed on: pull_request: + paths: + - 'proto/**' + push: + branches: + - master + paths: + - 'proto/**' jobs: lint: runs-on: ubuntu-latest timeout-minutes: 5 steps: - - uses: actions/checkout@master - - uses: technote-space/get-diff-action@v6.0.1 - with: - PATTERNS: | - **/**.proto - - name: lint - run: make proto-lint - if: env.GIT_DIFF + - uses: actions/checkout@v2 + - uses: bufbuild/buf-setup-action@v0.6.0 + - uses: bufbuild/buf-lint-action@v1 + with: + input: 'proto' + breakage: runs-on: ubuntu-latest steps: - - uses: actions/checkout@master - - uses: technote-space/get-diff-action@v6.0.1 + - uses: actions/checkout@v2 + - uses: bufbuild/buf-setup-action@v0.6.0 + - uses: bufbuild/buf-breaking-action@v1 + with: + input: 'proto' + against: 'https://github.com/${GITHUB_REPOSITORY}#branch=master,ref=HEAD~1,subdir=proto' + push: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v2 + - uses: bufbuild/buf-setup-action@v0.6.0 + - uses: bufbuild/buf-push-action@v1 with: - PATTERNS: | - **/**.proto - - name: check-breakage - run: make proto-check-breaking - if: env.GIT_DIFF + buf_token: ${{ secrets.BUF_TOKEN }} + if: ${{ steps.extract_branch.outputs.branch }} == master + From 1da7f7857d32b92b0db53f81e10859cfe17db315 Mon Sep 17 00:00:00 2001 From: marbar3778 Date: Mon, 31 Jan 2022 10:40:44 +0000 Subject: [PATCH 02/28] check breakage against target branch --- .github/workflows/proto.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/proto.yml b/.github/workflows/proto.yml index ea622e68f086..2a8f0d8fe0fd 100644 --- a/.github/workflows/proto.yml +++ b/.github/workflows/proto.yml @@ -30,7 +30,7 @@ jobs: - uses: bufbuild/buf-breaking-action@v1 with: input: 'proto' - against: 'https://github.com/${GITHUB_REPOSITORY}#branch=master,ref=HEAD~1,subdir=proto' + against: 'https://github.com/${GITHUB_REPOSITORY}#branch=${{ github.event.pull_request.base.ref }},ref=HEAD~1,subdir=proto' push: runs-on: ubuntu-latest steps: From 709242e4532d3debbeadb81f71013a337adf26de Mon Sep 17 00:00:00 2001 From: marbar3778 Date: Mon, 31 Jan 2022 10:46:15 +0000 Subject: [PATCH 03/28] test proto --- .github/workflows/proto.yml | 1 + proto/cosmos/bank/v1beta1/bank.proto | 9 --------- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/.github/workflows/proto.yml b/.github/workflows/proto.yml index 2a8f0d8fe0fd..48366b40dc9a 100644 --- a/.github/workflows/proto.yml +++ b/.github/workflows/proto.yml @@ -31,6 +31,7 @@ jobs: with: input: 'proto' against: 'https://github.com/${GITHUB_REPOSITORY}#branch=${{ github.event.pull_request.base.ref }},ref=HEAD~1,subdir=proto' + push: runs-on: ubuntu-latest steps: diff --git a/proto/cosmos/bank/v1beta1/bank.proto b/proto/cosmos/bank/v1beta1/bank.proto index 84717ffb555d..e05bf4886111 100644 --- a/proto/cosmos/bank/v1beta1/bank.proto +++ b/proto/cosmos/bank/v1beta1/bank.proto @@ -15,15 +15,6 @@ message Params { bool default_send_enabled = 2; } -// SendEnabled maps coin denom to a send_enabled status (whether a denom is -// sendable). -message SendEnabled { - option (gogoproto.equal) = true; - option (gogoproto.goproto_stringer) = false; - string denom = 1; - bool enabled = 2; -} - // Input models transaction input. message Input { option (cosmos.msg.v1.signer) = "address"; From 81872a57eaaacb23e1ddc5f1d23ba29e6cba1fb9 Mon Sep 17 00:00:00 2001 From: marbar3778 Date: Mon, 31 Jan 2022 10:48:25 +0000 Subject: [PATCH 04/28] fix repo --- .github/workflows/proto.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/proto.yml b/.github/workflows/proto.yml index 48366b40dc9a..ec4bacfddf89 100644 --- a/.github/workflows/proto.yml +++ b/.github/workflows/proto.yml @@ -30,7 +30,7 @@ jobs: - uses: bufbuild/buf-breaking-action@v1 with: input: 'proto' - against: 'https://github.com/${GITHUB_REPOSITORY}#branch=${{ github.event.pull_request.base.ref }},ref=HEAD~1,subdir=proto' + against: 'https://github.com/${{ github.repository }}#branch=${{ github.event.pull_request.base.ref }},ref=HEAD~1,subdir=proto' push: runs-on: ubuntu-latest From a28d909e9ef35918e175110d78ecc7bde054c262 Mon Sep 17 00:00:00 2001 From: marbar3778 Date: Mon, 31 Jan 2022 10:51:02 +0000 Subject: [PATCH 05/28] setinput --- .github/workflows/proto.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/proto.yml b/.github/workflows/proto.yml index ec4bacfddf89..0b7d45cc372e 100644 --- a/.github/workflows/proto.yml +++ b/.github/workflows/proto.yml @@ -22,7 +22,7 @@ jobs: with: input: 'proto' - breakage: + break-check: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 @@ -34,11 +34,13 @@ jobs: push: runs-on: ubuntu-latest + needs: [lint,break-check] steps: - uses: actions/checkout@v2 - uses: bufbuild/buf-setup-action@v0.6.0 - uses: bufbuild/buf-push-action@v1 with: + input: 'proto' buf_token: ${{ secrets.BUF_TOKEN }} if: ${{ steps.extract_branch.outputs.branch }} == master From 7e2beef91b0bec619d5461e1c212edeb655bec69 Mon Sep 17 00:00:00 2001 From: marbar3778 Date: Mon, 31 Jan 2022 10:53:34 +0000 Subject: [PATCH 06/28] undo proto change --- proto/cosmos/bank/v1beta1/bank.proto | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/proto/cosmos/bank/v1beta1/bank.proto b/proto/cosmos/bank/v1beta1/bank.proto index e05bf4886111..84717ffb555d 100644 --- a/proto/cosmos/bank/v1beta1/bank.proto +++ b/proto/cosmos/bank/v1beta1/bank.proto @@ -15,6 +15,15 @@ message Params { bool default_send_enabled = 2; } +// SendEnabled maps coin denom to a send_enabled status (whether a denom is +// sendable). +message SendEnabled { + option (gogoproto.equal) = true; + option (gogoproto.goproto_stringer) = false; + string denom = 1; + bool enabled = 2; +} + // Input models transaction input. message Input { option (cosmos.msg.v1.signer) = "address"; From 79bdd8323df77d0cd9c8dff4d9df76685183bc8c Mon Sep 17 00:00:00 2001 From: marbar3778 Date: Mon, 31 Jan 2022 10:55:00 +0000 Subject: [PATCH 07/28] minor change --- proto/cosmos/bank/v1beta1/bank.proto | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/proto/cosmos/bank/v1beta1/bank.proto b/proto/cosmos/bank/v1beta1/bank.proto index 84717ffb555d..27f3a4072293 100644 --- a/proto/cosmos/bank/v1beta1/bank.proto +++ b/proto/cosmos/bank/v1beta1/bank.proto @@ -26,8 +26,7 @@ message SendEnabled { // Input models transaction input. message Input { - option (cosmos.msg.v1.signer) = "address"; - + option (cosmos.msg.v1.signer) = "address"; option (gogoproto.equal) = false; option (gogoproto.goproto_getters) = false; From 15ad8c750796ff377da3fd9709af2e8df07db1e1 Mon Sep 17 00:00:00 2001 From: marbar3778 Date: Tue, 1 Feb 2022 09:50:54 +0100 Subject: [PATCH 08/28] test without subdir --- .github/workflows/proto.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/proto.yml b/.github/workflows/proto.yml index 0b7d45cc372e..d310b82c2eca 100644 --- a/.github/workflows/proto.yml +++ b/.github/workflows/proto.yml @@ -30,7 +30,7 @@ jobs: - uses: bufbuild/buf-breaking-action@v1 with: input: 'proto' - against: 'https://github.com/${{ github.repository }}#branch=${{ github.event.pull_request.base.ref }},ref=HEAD~1,subdir=proto' + against: 'https://github.com/${{ github.repository }}#branch=${{ github.event.pull_request.base.ref }},ref=HEAD~1' push: runs-on: ubuntu-latest From f0b7836cc506f68b36a6d17bdc9ce9f75354e86c Mon Sep 17 00:00:00 2001 From: marbar3778 Date: Tue, 1 Feb 2022 09:59:47 +0100 Subject: [PATCH 09/28] addback subdir --- .github/workflows/proto.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/proto.yml b/.github/workflows/proto.yml index d310b82c2eca..0b7d45cc372e 100644 --- a/.github/workflows/proto.yml +++ b/.github/workflows/proto.yml @@ -30,7 +30,7 @@ jobs: - uses: bufbuild/buf-breaking-action@v1 with: input: 'proto' - against: 'https://github.com/${{ github.repository }}#branch=${{ github.event.pull_request.base.ref }},ref=HEAD~1' + against: 'https://github.com/${{ github.repository }}#branch=${{ github.event.pull_request.base.ref }},ref=HEAD~1,subdir=proto' push: runs-on: ubuntu-latest From eca0acadcbb820a168c2a940cc02f1226e39ce30 Mon Sep 17 00:00:00 2001 From: marbar3778 Date: Tue, 1 Feb 2022 10:12:57 +0100 Subject: [PATCH 10/28] try without input --- .github/workflows/proto.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/proto.yml b/.github/workflows/proto.yml index 0b7d45cc372e..625a061156af 100644 --- a/.github/workflows/proto.yml +++ b/.github/workflows/proto.yml @@ -29,8 +29,7 @@ jobs: - uses: bufbuild/buf-setup-action@v0.6.0 - uses: bufbuild/buf-breaking-action@v1 with: - input: 'proto' - against: 'https://github.com/${{ github.repository }}#branch=${{ github.event.pull_request.base.ref }},ref=HEAD~1,subdir=proto' + against: 'https://github.com/${{ github.repository }}#branch=${{ github.event.pull_request.base.ref }},ref=HEAD~1 push: runs-on: ubuntu-latest From 62d06a05e257fa4c392c0d5d5e09e5be9ed492be Mon Sep 17 00:00:00 2001 From: marbar3778 Date: Tue, 1 Feb 2022 11:56:01 +0100 Subject: [PATCH 11/28] proto change --- proto/cosmos/authz/v1beta1/authz.proto | 1 - 1 file changed, 1 deletion(-) diff --git a/proto/cosmos/authz/v1beta1/authz.proto b/proto/cosmos/authz/v1beta1/authz.proto index 2c376905eb8b..026088826b68 100644 --- a/proto/cosmos/authz/v1beta1/authz.proto +++ b/proto/cosmos/authz/v1beta1/authz.proto @@ -14,7 +14,6 @@ option (gogoproto.goproto_getters_all) = false; // the provided method on behalf of the granter's account. message GenericAuthorization { option (cosmos_proto.implements_interface) = "Authorization"; - // Msg, identified by it's type URL, to grant unrestricted permissions to execute string msg = 1; } From 999ce7b5295ed7d486e51a3789655cbe170cab5e Mon Sep 17 00:00:00 2001 From: marbar3778 Date: Tue, 1 Feb 2022 11:57:17 +0100 Subject: [PATCH 12/28] fix ci --- .github/workflows/proto.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/proto.yml b/.github/workflows/proto.yml index 625a061156af..a1070848061f 100644 --- a/.github/workflows/proto.yml +++ b/.github/workflows/proto.yml @@ -29,8 +29,7 @@ jobs: - uses: bufbuild/buf-setup-action@v0.6.0 - uses: bufbuild/buf-breaking-action@v1 with: - against: 'https://github.com/${{ github.repository }}#branch=${{ github.event.pull_request.base.ref }},ref=HEAD~1 - + against: 'https://github.com/${{ github.repository }}#branch=${{ github.event.pull_request.base.ref }},ref=HEAD~1' push: runs-on: ubuntu-latest needs: [lint,break-check] From ea30b95804dac0013da58198607e09a354fec990 Mon Sep 17 00:00:00 2001 From: marbar3778 Date: Tue, 1 Feb 2022 12:07:22 +0100 Subject: [PATCH 13/28] remove head --- .github/workflows/proto.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/proto.yml b/.github/workflows/proto.yml index a1070848061f..04b0ca73ef08 100644 --- a/.github/workflows/proto.yml +++ b/.github/workflows/proto.yml @@ -29,7 +29,7 @@ jobs: - uses: bufbuild/buf-setup-action@v0.6.0 - uses: bufbuild/buf-breaking-action@v1 with: - against: 'https://github.com/${{ github.repository }}#branch=${{ github.event.pull_request.base.ref }},ref=HEAD~1' + against: 'https://github.com/${{ github.repository }}#branch=${{ github.event.pull_request.base.ref }}' push: runs-on: ubuntu-latest needs: [lint,break-check] From bd50407e5647a27a65313d9b509b3ca990921707 Mon Sep 17 00:00:00 2001 From: marbar3778 Date: Tue, 1 Feb 2022 12:20:23 +0100 Subject: [PATCH 14/28] add proto --- .github/workflows/proto.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/proto.yml b/.github/workflows/proto.yml index 04b0ca73ef08..5eb348f120e3 100644 --- a/.github/workflows/proto.yml +++ b/.github/workflows/proto.yml @@ -29,6 +29,7 @@ jobs: - uses: bufbuild/buf-setup-action@v0.6.0 - uses: bufbuild/buf-breaking-action@v1 with: + input: 'proto' against: 'https://github.com/${{ github.repository }}#branch=${{ github.event.pull_request.base.ref }}' push: runs-on: ubuntu-latest From 6c91fc7588a91bb322c12de0310147ccab1bdeee Mon Sep 17 00:00:00 2001 From: marbar3778 Date: Tue, 1 Feb 2022 12:50:29 +0100 Subject: [PATCH 15/28] add back --- .github/workflows/proto.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/proto.yml b/.github/workflows/proto.yml index 5eb348f120e3..6db44856c428 100644 --- a/.github/workflows/proto.yml +++ b/.github/workflows/proto.yml @@ -30,7 +30,7 @@ jobs: - uses: bufbuild/buf-breaking-action@v1 with: input: 'proto' - against: 'https://github.com/${{ github.repository }}#branch=${{ github.event.pull_request.base.ref }}' + against: 'https://github.com/${{ github.repository }}#branch=${{ github.event.pull_request.base.ref }},ref=HEAD~1,subdir=proto' push: runs-on: ubuntu-latest needs: [lint,break-check] From 33ab39faa35b91bddbff16974f58146af6d8e029 Mon Sep 17 00:00:00 2001 From: marbar3778 Date: Tue, 1 Feb 2022 15:24:52 +0100 Subject: [PATCH 16/28] add .git --- .github/workflows/proto.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/proto.yml b/.github/workflows/proto.yml index 6db44856c428..26ff232c6988 100644 --- a/.github/workflows/proto.yml +++ b/.github/workflows/proto.yml @@ -30,7 +30,7 @@ jobs: - uses: bufbuild/buf-breaking-action@v1 with: input: 'proto' - against: 'https://github.com/${{ github.repository }}#branch=${{ github.event.pull_request.base.ref }},ref=HEAD~1,subdir=proto' + against: 'https://github.com/${{ github.repository }}.git#branch=${{ github.event.pull_request.base.ref }},ref=HEAD~1,subdir=proto' push: runs-on: ubuntu-latest needs: [lint,break-check] From 4b414e642aa0ad1ab6c582c837f350ead1ee3be1 Mon Sep 17 00:00:00 2001 From: marbar3778 Date: Tue, 1 Feb 2022 15:27:06 +0100 Subject: [PATCH 17/28] test --- .github/workflows/proto.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/proto.yml b/.github/workflows/proto.yml index 26ff232c6988..b5436368dfaa 100644 --- a/.github/workflows/proto.yml +++ b/.github/workflows/proto.yml @@ -37,6 +37,8 @@ jobs: steps: - uses: actions/checkout@v2 - uses: bufbuild/buf-setup-action@v0.6.0 + - run: | + echo ${{ steps.extract_branch.outputs.branch }} - uses: bufbuild/buf-push-action@v1 with: input: 'proto' From 438ebdd174f6e6b7a10e6dbd86b404ff79f69495 Mon Sep 17 00:00:00 2001 From: marbar3778 Date: Tue, 1 Feb 2022 15:38:17 +0100 Subject: [PATCH 18/28] test++ --- .github/workflows/proto.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/proto.yml b/.github/workflows/proto.yml index b5436368dfaa..f8d8cdcf0e06 100644 --- a/.github/workflows/proto.yml +++ b/.github/workflows/proto.yml @@ -34,14 +34,12 @@ jobs: push: runs-on: ubuntu-latest needs: [lint,break-check] + if: ${{ steps.extract_branch.outputs.branch }} == ${{ github.event.repository.default_branch }} steps: - uses: actions/checkout@v2 - uses: bufbuild/buf-setup-action@v0.6.0 - - run: | - echo ${{ steps.extract_branch.outputs.branch }} - uses: bufbuild/buf-push-action@v1 with: input: 'proto' buf_token: ${{ secrets.BUF_TOKEN }} - if: ${{ steps.extract_branch.outputs.branch }} == master From d81078e6958789ff03eb55e71c36c29ec242555a Mon Sep 17 00:00:00 2001 From: marbar3778 Date: Tue, 1 Feb 2022 15:40:44 +0100 Subject: [PATCH 19/28] test+++ --- .github/workflows/proto.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/proto.yml b/.github/workflows/proto.yml index f8d8cdcf0e06..48614cd04345 100644 --- a/.github/workflows/proto.yml +++ b/.github/workflows/proto.yml @@ -34,7 +34,7 @@ jobs: push: runs-on: ubuntu-latest needs: [lint,break-check] - if: ${{ steps.extract_branch.outputs.branch }} == ${{ github.event.repository.default_branch }} + if: ${{ steps.extract_branch.outputs.branch }} == 'master' steps: - uses: actions/checkout@v2 - uses: bufbuild/buf-setup-action@v0.6.0 From 6e45245947df3a20c71743a3573e873dcd68445c Mon Sep 17 00:00:00 2001 From: marbar3778 Date: Tue, 1 Feb 2022 15:42:29 +0100 Subject: [PATCH 20/28] something --- .github/workflows/proto.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/proto.yml b/.github/workflows/proto.yml index 48614cd04345..8ca11e72be7a 100644 --- a/.github/workflows/proto.yml +++ b/.github/workflows/proto.yml @@ -32,9 +32,9 @@ jobs: input: 'proto' against: 'https://github.com/${{ github.repository }}.git#branch=${{ github.event.pull_request.base.ref }},ref=HEAD~1,subdir=proto' push: + if: steps.extract_branch.outputs.branch == 'master' runs-on: ubuntu-latest needs: [lint,break-check] - if: ${{ steps.extract_branch.outputs.branch }} == 'master' steps: - uses: actions/checkout@v2 - uses: bufbuild/buf-setup-action@v0.6.0 From c10b1420263ad23c61adbc927b40291c66abd25e Mon Sep 17 00:00:00 2001 From: marbar3778 Date: Tue, 1 Feb 2022 15:43:45 +0100 Subject: [PATCH 21/28] something --- .github/workflows/proto.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/proto.yml b/.github/workflows/proto.yml index 8ca11e72be7a..3c684ac63113 100644 --- a/.github/workflows/proto.yml +++ b/.github/workflows/proto.yml @@ -32,7 +32,6 @@ jobs: input: 'proto' against: 'https://github.com/${{ github.repository }}.git#branch=${{ github.event.pull_request.base.ref }},ref=HEAD~1,subdir=proto' push: - if: steps.extract_branch.outputs.branch == 'master' runs-on: ubuntu-latest needs: [lint,break-check] steps: From d0f51bb2fcd770c97558740daa4b7a5428cc993c Mon Sep 17 00:00:00 2001 From: marbar3778 Date: Tue, 1 Feb 2022 15:56:13 +0100 Subject: [PATCH 22/28] something++ --- .github/workflows/proto.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/proto.yml b/.github/workflows/proto.yml index 3c684ac63113..51bc24300da4 100644 --- a/.github/workflows/proto.yml +++ b/.github/workflows/proto.yml @@ -41,4 +41,5 @@ jobs: with: input: 'proto' buf_token: ${{ secrets.BUF_TOKEN }} + if: ${{env.GITHUB_REF_NAME}} == 'master' From d0a5a8570cd3816b2e20a26099cad06558268e78 Mon Sep 17 00:00:00 2001 From: marbar3778 Date: Tue, 1 Feb 2022 15:58:15 +0100 Subject: [PATCH 23/28] test --- .github/workflows/proto.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/proto.yml b/.github/workflows/proto.yml index 51bc24300da4..3c684ac63113 100644 --- a/.github/workflows/proto.yml +++ b/.github/workflows/proto.yml @@ -41,5 +41,4 @@ jobs: with: input: 'proto' buf_token: ${{ secrets.BUF_TOKEN }} - if: ${{env.GITHUB_REF_NAME}} == 'master' From 481ee3c920b01a6f4ae1f5bed572290ac3fbf287 Mon Sep 17 00:00:00 2001 From: marbar3778 Date: Tue, 1 Feb 2022 16:26:18 +0100 Subject: [PATCH 24/28] test --- .github/workflows/proto.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/proto.yml b/.github/workflows/proto.yml index 3c684ac63113..16d53400f6c7 100644 --- a/.github/workflows/proto.yml +++ b/.github/workflows/proto.yml @@ -41,4 +41,5 @@ jobs: with: input: 'proto' buf_token: ${{ secrets.BUF_TOKEN }} + if: ${{ GITHUB_REF##*/ }} == 'master' From 2271633ce2351b0495e950ecc0db550725955f59 Mon Sep 17 00:00:00 2001 From: marbar3778 Date: Tue, 1 Feb 2022 16:32:30 +0100 Subject: [PATCH 25/28] do different design --- .github/workflows/proto-registry.yml | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 .github/workflows/proto-registry.yml diff --git a/.github/workflows/proto-registry.yml b/.github/workflows/proto-registry.yml new file mode 100644 index 000000000000..aee0ab71f620 --- /dev/null +++ b/.github/workflows/proto-registry.yml @@ -0,0 +1,21 @@ +name: Buf-Push +# Protobuf runs buf (https://buf.build/) lint and check-breakage +# This workflow is only run when a .proto file has been changed +on: + push: + branches: + - master + paths: + - 'proto/**' + +jobs: + push: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v2 + - uses: bufbuild/buf-setup-action@v0.6.0 + - uses: bufbuild/buf-push-action@v1 + with: + input: 'proto' + buf_token: ${{ secrets.BUF_TOKEN }} + From aefbac8de3b637f33bca0613076af434f0b13d93 Mon Sep 17 00:00:00 2001 From: marbar3778 Date: Tue, 1 Feb 2022 16:33:28 +0100 Subject: [PATCH 26/28] revert proto change --- proto/cosmos/authz/v1beta1/authz.proto | 1 + proto/cosmos/bank/v1beta1/bank.proto | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/proto/cosmos/authz/v1beta1/authz.proto b/proto/cosmos/authz/v1beta1/authz.proto index 026088826b68..2c376905eb8b 100644 --- a/proto/cosmos/authz/v1beta1/authz.proto +++ b/proto/cosmos/authz/v1beta1/authz.proto @@ -14,6 +14,7 @@ option (gogoproto.goproto_getters_all) = false; // the provided method on behalf of the granter's account. message GenericAuthorization { option (cosmos_proto.implements_interface) = "Authorization"; + // Msg, identified by it's type URL, to grant unrestricted permissions to execute string msg = 1; } diff --git a/proto/cosmos/bank/v1beta1/bank.proto b/proto/cosmos/bank/v1beta1/bank.proto index 27f3a4072293..84717ffb555d 100644 --- a/proto/cosmos/bank/v1beta1/bank.proto +++ b/proto/cosmos/bank/v1beta1/bank.proto @@ -26,7 +26,8 @@ message SendEnabled { // Input models transaction input. message Input { - option (cosmos.msg.v1.signer) = "address"; + option (cosmos.msg.v1.signer) = "address"; + option (gogoproto.equal) = false; option (gogoproto.goproto_getters) = false; From cb20ad99775bc59d35875799953ee8955ad2e93e Mon Sep 17 00:00:00 2001 From: marbar3778 Date: Tue, 1 Feb 2022 16:36:44 +0100 Subject: [PATCH 27/28] docs --- .github/workflows/proto.yml | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/.github/workflows/proto.yml b/.github/workflows/proto.yml index 16d53400f6c7..9e2e96f8531e 100644 --- a/.github/workflows/proto.yml +++ b/.github/workflows/proto.yml @@ -1,5 +1,5 @@ name: Protobuf -# Protobuf runs buf (https://buf.build/) lint and check-breakage +# Protobuf runs buf (https://buf.build/) push updated proto to https://buf.build/cosmos/cosmos-sdk # This workflow is only run when a .proto file has been changed on: pull_request: @@ -31,15 +31,3 @@ jobs: with: input: 'proto' against: 'https://github.com/${{ github.repository }}.git#branch=${{ github.event.pull_request.base.ref }},ref=HEAD~1,subdir=proto' - push: - runs-on: ubuntu-latest - needs: [lint,break-check] - steps: - - uses: actions/checkout@v2 - - uses: bufbuild/buf-setup-action@v0.6.0 - - uses: bufbuild/buf-push-action@v1 - with: - input: 'proto' - buf_token: ${{ secrets.BUF_TOKEN }} - if: ${{ GITHUB_REF##*/ }} == 'master' - From 3e02cdcba1083f2d54c2eacbe0c23083d030479a Mon Sep 17 00:00:00 2001 From: marbar3778 Date: Tue, 1 Feb 2022 16:37:44 +0100 Subject: [PATCH 28/28] revert comment --- .github/workflows/proto-registry.yml | 2 +- .github/workflows/proto.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/proto-registry.yml b/.github/workflows/proto-registry.yml index aee0ab71f620..79cf58e659ea 100644 --- a/.github/workflows/proto-registry.yml +++ b/.github/workflows/proto-registry.yml @@ -1,5 +1,5 @@ name: Buf-Push -# Protobuf runs buf (https://buf.build/) lint and check-breakage +# Protobuf runs buf (https://buf.build/) push updated proto files to https://buf.build/cosmos/cosmos-sdk # This workflow is only run when a .proto file has been changed on: push: diff --git a/.github/workflows/proto.yml b/.github/workflows/proto.yml index 9e2e96f8531e..105c3fb90477 100644 --- a/.github/workflows/proto.yml +++ b/.github/workflows/proto.yml @@ -1,5 +1,5 @@ name: Protobuf -# Protobuf runs buf (https://buf.build/) push updated proto to https://buf.build/cosmos/cosmos-sdk +# Protobuf runs buf (https://buf.build/) lint and check-breakage # This workflow is only run when a .proto file has been changed on: pull_request: