Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple vesting locks per account #9959

Closed
aaronc opened this issue Aug 17, 2021 · 5 comments
Closed

Allow multiple vesting locks per account #9959

aaronc opened this issue Aug 17, 2021 · 5 comments
Labels

Comments

@aaronc
Copy link
Member

aaronc commented Aug 17, 2021

No description provided.

@JimLarson
Copy link
Contributor

FYI, in the Agoric fork we had the following issue for allowing multiple locked-up grants to the same PeriodicVestingAccount: Agoric/agoric-sdk#3956

It was implemented in the following PR: agoric-labs#136

@tac0turtle
Copy link
Member

@JimLarson it seems agaric has put a lot of work into vesting, Id love to come up with a plan of upstreaming this work since most the vesting issues in the sdk seem to be solved with your work.

@alexanderbez
Copy link
Contributor

Yes, please! Getting a clawback mechanism would be super beneficial to have in the SDK's vesting account types.

@JimLarson
Copy link
Contributor

Great! I'd love to chat about upstreaming plans.

BTW, I found an issue with agoric-labs#136 (that also affects Clawback vesting accounts). The current vesting account bookkeeping for delegated tokens assumes that the unvested amount is monotonically decreasing. If we allow new vesting grants into existing accounts, then slashing can lead to future grants being unlocked prematurely. One solution is to add a new feature to x/staking to get a balance of the current bonded and unbonding amounts, where the result is cached for efficiency but invalidated after a new slashing event.

See Agoric/agoric-sdk#4300

@tac0turtle
Copy link
Member

closing this in favour of #14900.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

4 participants