Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistent gentx --pubkey CLI input in 0.43.0-rc2 #9819

Closed
4 tasks
tomtau opened this issue Jul 30, 2021 · 1 comment · Fixed by #9827
Closed
4 tasks

inconsistent gentx --pubkey CLI input in 0.43.0-rc2 #9819

tomtau opened this issue Jul 30, 2021 · 1 comment · Fixed by #9827

Comments

@tomtau
Copy link
Contributor

tomtau commented Jul 30, 2021

Summary of Bug

Currently, gentx expects the validator public in the following format:

{"key":"<base64 payload>"}

On the other hand tx staking create-validator expects in the following format:

{"@type":"/cosmos.crypto.ed25519.PubKey","key":"<base64 payload>"}

In addition to that, the CLI help prompts are incorrect:

      --pubkey string                       The Bech32 encoded PubKey of the validator

Version

0.43.0-rc2

Steps to Reproduce

Build an app with against SDK v0.43.0-rc2 (e.g. simapp) and run gentx or tx staking create-validator.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@alexanderbez
Copy link
Contributor

Thanks for pointing this out @tomtau 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants