Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After an upgrade, what is the date of the first block? #9085

Closed
shahankhatch opened this issue Apr 8, 2021 · 4 comments · Fixed by #9090
Closed

After an upgrade, what is the date of the first block? #9085

shahankhatch opened this issue Apr 8, 2021 · 4 comments · Fixed by #9090

Comments

@shahankhatch
Copy link
Contributor

In the migration from cosmoshub-3 to cosmoshub-4, the first block after the upgrade doesn't have a 'valid' timestamp.

E.g., https://www.mintscan.io/cosmos/blocks/5200791
https://atom.tokenview.com/en/block/5200791

The block right before and after seem to have valid timestamps. Initially, this looks like a data formatting error, but it's also possible that the first block after an upgrade doesn't validate the timestamp to be after the last exported block.

@tac0turtle
Copy link
Member

It's the timestamp of the start of cosmoshub-3. I think this is some oversight in the sdk or Tendermint when genesis files are exported.

@tac0turtle
Copy link
Member

This is also mentioned in the docs:

Note: The migrate command takes an input genesis state and migrates it to a targeted version. New genesis-time will be as mentioned in the governance proposal.

seems this doesnt work as intended

cc @AmauryM

@amaury1093
Copy link
Contributor

amaury1093 commented Apr 9, 2021

The migrate command takes a --genesis-time, and then we set this time in the Tendermint genesisDoc, and that's the genesis time of the new chain.

Did the cosmoshub-3 to cosmoshub-4 run with --genesis-time? If no, then it seems to me that it's not a bug, but maybe some docs improvement to clarify this, I can take care of it.

@tac0turtle
Copy link
Member

Did the cosmoshub-3 to cosmoshub-4 run with --genesis-time? If no, then it seems to me that it's not a bug, but maybe some docs improvement to clarify this, I can take care of it.

It was not (https://github.com/cosmos/gaia/blob/main/docs/migration/cosmoshub-3.md). Seems this was an oversight on the gaia upgrade process.

Thank you @AmauryM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants