Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy code <=0.38 #8678

Closed
6 tasks
amaury1093 opened this issue Feb 23, 2021 · 2 comments · Fixed by #9291
Closed
6 tasks

Remove legacy code <=0.38 #8678

amaury1093 opened this issue Feb 23, 2021 · 2 comments · Fixed by #9291
Labels
Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.

Comments

@amaury1093
Copy link
Contributor

Summary

We should remove all legacy code for SDK versions 0.38 (incl.) and before.

Problem Definition

Legacy code makes the codebase bigger, tests slower, lints slower. And they are not maintained.

Proposal

  • Remove all code that touches SDK v<=0.38. I can only think of simd migrate commands, but maybe there's something else. We would only offer 0.39 onwards migrations.
    • if users want to do migrations of older versions of the SDK, they can still download an old binary.
  • Add documentation on how to perform older migrations.

cc @robert-zaremba @alessio


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@amaury1093 amaury1093 added the Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. label Feb 23, 2021
@alessio
Copy link
Contributor

alessio commented Feb 23, 2021

ACK from me.

@robert-zaremba
Copy link
Collaborator

Fully support that. We had few discussion about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants