Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty accounts in validate-genesis #8626

Closed
4 tasks
anilcse opened this issue Feb 18, 2021 · 2 comments · Fixed by #8714
Closed
4 tasks

Allow empty accounts in validate-genesis #8626

anilcse opened this issue Feb 18, 2021 · 2 comments · Fixed by #8714
Assignees
Labels
C:genesis relating to chain genesis
Milestone

Comments

@anilcse
Copy link
Collaborator

anilcse commented Feb 18, 2021

Summary

We've experienced Error: error validating genesis file genesis.json: empty or nil coins for address error on validate-genesis cmd in one of our internal testnets. It found out to be with a module account, which had no tokens at the time of exporting the state (we tried to validate the exported genesis). I believe module accounts can be without any tokens so, this validation can be removed.

While digging through this, it's seems like it is not valid anymore to have this check on any address. Because x/feegrant and x/authz would allow authorizing accounts with no balances as well. So empty accounts are still valid there.

Proposal

Allow empty accounts in the genesis and remove the check in validate genesis


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@amaury1093 amaury1093 added the C:genesis relating to chain genesis label Feb 22, 2021
@clevinson
Copy link
Contributor

Seems like a valid request to me. Should we try and get this in before 0.42?

@tac0turtle
Copy link
Member

tac0turtle commented Feb 26, 2021

this is present on the cosmoshub as well. we should try to get it into the next release

gaiad validate-genesis
Error: error validating genesis file /Users/markobaricevic/.gaia/config/genesis.json: empty or nil coins for address cosmos1qqq9nqqllyvqfzen9w2sr0zp8jsfnycsjs8qwv

@amaury1093 amaury1093 added this to the v0.42 milestone Feb 26, 2021
@alessio alessio modified the milestones: v0.42, v0.41.X Feb 26, 2021
@alessio alessio mentioned this issue Feb 26, 2021
9 tasks
@mergify mergify bot closed this as completed in #8714 Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:genesis relating to chain genesis
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants