Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a name to crisis invariants, and print these in logs #8621

Closed
4 tasks
ValarDragon opened this issue Feb 18, 2021 · 0 comments · Fixed by #8785
Closed
4 tasks

Add a name to crisis invariants, and print these in logs #8621

ValarDragon opened this issue Feb 18, 2021 · 0 comments · Fixed by #8785
Assignees

Comments

@ValarDragon
Copy link
Contributor

ValarDragon commented Feb 18, 2021

Summary

Currently crisis invariant checks look like:

7:47AM INF asserting crisis invariants inv=0/11 module=x/crisis
7:47AM INF asserting crisis invariants inv=1/11 module=x/crisis
7:47AM INF asserting crisis invariants inv=2/11 module=x/crisis 
7:47AM INF asserting crisis invariants inv=3/11 module=x/crisis
7:47AM INF asserting crisis invariants inv=4/11 module=x/crisis

It would be nice if there could also be a human friendly name printed out for what the invariant being checked is.

Problem Definition

Improves understandability of logs, and helps node operators learn what the invariants being checked are.

Proposal

Use the existing name field associated with every invariant, and print them in the crisis invariant log line as:

7:47AM INF asserting crisis invariants inv=2/11 name=$INVARIANT_NAME module=x/crisis


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@tac0turtle tac0turtle self-assigned this Mar 4, 2021
@mergify mergify bot closed this as completed in #8785 Mar 4, 2021
@aaronc aaronc removed the in progress label Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants