Rename codec.Marshaler

[robert-zaremba]

Summary

codec.Marshaler and codec.ProtoMarshaler have similar name but totally different responsibility.

Problem Definition

codec.ProtoMarshaler, similar to json.Marshaler, is for self marshaling.
codec.Marshaler, on the other hand, is for marshaling other objects. Reading the name I would assume that both are of the same kind, but they have completely different responsibility.

Proposal

Two options:

• rename codec.ProtoMarshaler to codec.Coder
• or remove the interface since we can use proto.Marshal -> ref: Use proto.Marshal for store objects Marshaling #8412
  • Note - we will need to move some helper methods out of the implementation to the codec package: methods related to interface (Any) marshaling.

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[aaronc]

How about we rename codec.Marshaler -> codec.Codec since the two implementations are ProtoCodec and AminoCodec. And similarly BinaryMarshaler and JSONMarshaler become BinaryCodec and JSONCodec.

[robert-zaremba]

So, object which serializes other objects will be called Codec*