Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove StdTxConfig and StdTx. #8189

Closed
2 of 4 tasks
robert-zaremba opened this issue Dec 17, 2020 · 0 comments · Fixed by #17985
Closed
2 of 4 tasks

Remove StdTxConfig and StdTx. #8189

robert-zaremba opened this issue Dec 17, 2020 · 0 comments · Fixed by #17985
Assignees
Labels
C:Encoding T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). T:tech debt Tech debt that should be cleaned up

Comments

@robert-zaremba
Copy link
Collaborator

Summary

StdTxConfig is marked deprecated and it's not supported any more.

Problem Definition

Since Stargate, whole storage is protobuf based and transactions are build using TxBuilder. We don't even test StdTxConfig. There are few hacks in the code to keep some compatibility for clients:

  • intoAny interface and AsAny method
  • sdk.TxResponse uses Any for wrapping transaction object -- it should use interface or store the concrete transaction object instead (personally I prefer the latter).
  • probably some decoder hacks.

Proposal

Remove the StdTxConfig and related hacks.

This issue is to keep track of this hacks and remove them.

References:


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@robert-zaremba robert-zaremba added Legacy API T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). C:Encoding labels Dec 17, 2020
@robert-zaremba robert-zaremba added this to the v0.41 milestone Dec 17, 2020
@aaronc aaronc modified the milestones: v0.41, v0.42 Jan 6, 2021
@tac0turtle tac0turtle added the T:tech debt Tech debt that should be cleaned up label Oct 21, 2022
@tac0turtle tac0turtle self-assigned this Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Encoding T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). T:tech debt Tech debt that should be cleaned up
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants