IBC send via broadcasting endpoint

[faboweb]

Summary of Bug

Using the POST /txs endpoint to broadcast a tx doesn't work for IBC sends. The message type is not recognized.

Message:

{
  "account_number": "68",
  "chain_id": "stargate-4",
  "fee": {
    "amount": [
      {
        "amount": "3500",
        "denom": "umuon"
      }
    ],
    "gas": "350000"
  },
  "memo": "",
  "msgs": [
    {
      "type": "cosmos-sdk/MsgTransfer",
      "value": {
        "receiver": "cosmos1q9wtnlwdjrhwtcjmt2uq77jrgx7z3usrq2yz7z",
        "sender": "cosmos1q9wtnlwdjrhwtcjmt2uq77jrgx7z3usrq2yz7z",
        "source_channel": "THEslipperCHANNEL",
        "source_port": "transfer",
        "token": {
          "amount": "1000000",
          "denom": "umuon"
        }
      }
    }
  ],
  "sequence": "24"
}

Response:

{"error":"unrecognized concrete type name cosmos-sdk/MsgTransfer"}

Version

Steps to Reproduce

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[aaronc]

IBC doesn't support Amino. You will need to use a protobuf Tx.

[faboweb]

Anyway to avoid introducing protobuf here?

[faboweb]

Why does the broadcasting endpoint not handle protobuf serialization?

[aaronc]

Anyway to avoid introducing protobuf here?

No

Why does the broadcasting endpoint not handle protobuf serialization?

It's an amino endpoint. The JSON you sent was amino and uses undefined types

[aaronc]

Can someone post the best available migration guide for @faboweb ? @amaurymartiny @anilcse @clevinson ?

[faboweb]

Why is this working then for every other transaction? Or will this not work either for other txs in the future? Please don't make this complicated ^^' Aaron Craelius <[email protected]> schrieb am Di., 24. Nov. 2020, 12:50:

…

Anyway to avoid introducing protobuf here? No Why does the broadcasting endpoint not handle protobuf serialization? It's an amino endpoint. The JSON you sent was amino and uses undefined types — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#8022 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABMY5WP3LMPV7UA3RIB33MLSRPW6JANCNFSM4UBEVEMA> .

[amaury1093]

The current docs for REST endpoints migration are here: https://docs.cosmos.network/master/migrations/rest.html

[aaronc]

IBC doesn't support amino at all. Other transactions which supported amino before still do but are being deprecated. In general, these endpoints are all deprecated and will stop working. They were left in place to allow for a less dramatic transition but they are basically unsupported and compatibility isn't guaranteed. We advise that you migrate to grpc or grpc gateway REST endpoints.

[faboweb]

oh boy, the pain just never stops...

[aaronc]

Sorry 🙁

[fedekunze]

new modules won't support amino at all as it will be deprecated and grpc/proto has a larger set of libraries for clients

[amaury1093]

We should definitely add a nicer error message here too, linking to the REST migration guide.

Edit: while we're at it, also add to the /txs/{en,de}code endpoints