Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CalculateGas to use proto-generated service client #7726

Closed
4 tasks
amaury1093 opened this issue Oct 29, 2020 · 0 comments · Fixed by #8926
Closed
4 tasks

Refactor CalculateGas to use proto-generated service client #7726

amaury1093 opened this issue Oct 29, 2020 · 0 comments · Fixed by #8926
Labels
Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.

Comments

@amaury1093
Copy link
Contributor

Summary of Refactor

Use the generated tx service client instead of hardcoding the gRPC route

ref: #7688 (comment)

Version

82f15f3

Description

Currently, the calculate gas makes a Tendermint query with a hardcoded gRPC route to the simulate service. This works, but we should prefer to use the generated client.

Proposed Refactor

txServiceClient = tx.NewServiceClient(clientCtx)
txServiceClient.Simulate(...)

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@amaury1093 amaury1093 added the Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. label Oct 29, 2020
@amaury1093 amaury1093 mentioned this issue Oct 29, 2020
11 tasks
@mergify mergify bot closed this as completed in #8926 Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant