-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename IBC Height's "Version" to a unique name for IBC #7709
Comments
Let's choose "revision" here. |
I'm still in favor of prefixing |
I don't think that would help in this case since a revision number is actually referencing the revision of a chain not a light client. ie cosmos-hub-4 is the 4th revision. From the implementation side, I think using |
This should be tackled after we merge the upgrade consensus state change to avoid merge conflicts |
Decided upon |
Summary
There continues to be confusion around the IBC height which originally used "epoch" and now uses "version". Version collides with the IAVL tree usage of version. We propose renaming the name to something that can be more uniquely identifier with IBC to avoid naming collision and confusion
@cwgoes proposed possibly using:
For Admin Use
The text was updated successfully, but these errors were encountered: