Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Fee from Auth Info, and put Signatures into it #7668

Closed
4 tasks
ValarDragon opened this issue Oct 24, 2020 · 1 comment
Closed
4 tasks

Remove Fee from Auth Info, and put Signatures into it #7668

ValarDragon opened this issue Oct 24, 2020 · 1 comment
Labels
C:x/auth T: ADR An issue or PR relating to an architectural decision record

Comments

@ValarDragon
Copy link
Contributor

I am looking at the structure of a tx, as described in this file
https://github.com/cosmos/cosmos-sdk/blob/4a1b2fba43b1052ca162b3a1e0b6db6db9c26656/proto/cosmos/tx/v1beta1/tx.proto

This structure is confusing, since it seems that "signer_info" is metadata describing the signature/who it comes from. Confusingly, the "signer info" is not packaged with the signature, and is instead packaged with the fees in a struct called "auth_info". This leads to a very unintuitive structure.

We propose the struct instead be

{
  Body
  Fee
  AuthInfo {
    SignerInfo
    Signatures
  }
}

Auth Info should be Authn depending on the decision in #7615
(Written jointly with @sunnya97 )


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ValarDragon ValarDragon added Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. C:x/auth labels Oct 24, 2020
@aaronc
Copy link
Member

aaronc commented Oct 25, 2020

Have you read through ADR 020 and all the surrounding discussions? Tx is organized the way it is to 1) expose the minimum malleability surface and 2) make client signing implementations as simple as possible. This is not just a code hygiene issue. I don't really feel that it will be productive for us to discuss aesthetics without considering all the other somewhat complex and subtle issues. And considering the quite lengthy discussions we already had, I'm pretty resistant to changing it again without a strong signing workflow or security reason.

@amaury1093 amaury1093 added T: ADR An issue or PR relating to an architectural decision record and removed Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. labels Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/auth T: ADR An issue or PR relating to an architectural decision record
Projects
None yet
Development

No branches or pull requests

3 participants