Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store/cachekv: descending *Iterators (aka cachekv.ReverseIterator) are untested nor is domain #6687

Closed
4 tasks
odeke-em opened this issue Jul 10, 2020 · 0 comments · Fixed by #13385
Closed
4 tasks

store/cachekv: descending *Iterators (aka cachekv.ReverseIterator) are untested nor is domain #6687

odeke-em opened this issue Jul 10, 2020 · 0 comments · Fixed by #13385
Labels
C:Store

Comments

@odeke-em
Copy link
Collaborator

During an audit, store/cachekv has good unit test coverage. However, only ascending iterators are tested. We need to also test descending iterators and also unit test the results from domain.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@tac0turtle tac0turtle mentioned this issue Aug 30, 2022
Closed
22 tasks
@facundomedica facundomedica mentioned this issue Sep 25, 2022
Merged
19 tasks
@tac0turtle tac0turtle moved this to 📝 Todo in Cosmos-SDK Sep 25, 2022
Repository owner moved this from 📝 Todo to 👏 Done in Cosmos-SDK Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:Store
Projects
Cosmos-SDK
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add cachekv tests cosmos/cosmos-sdk
2 participants
@odeke-em @tac0turtle