Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST query /gov/proposals does not support pagination. #5212

Closed
4 tasks
jnaviask opened this issue Oct 16, 2019 · 0 comments · Fixed by #5216
Closed
4 tasks

REST query /gov/proposals does not support pagination. #5212

jnaviask opened this issue Oct 16, 2019 · 0 comments · Fixed by #5216
Assignees
Labels

Comments

@jnaviask
Copy link

Summary of Bug

The /gov/proposals query is still using an older form of parsing limit and page arguments, as seen in this function: https://github.com/cosmos/cosmos-sdk/blob/v0.37.3/x/gov/client/rest/rest.go#L558. As a result, pagination does not work as expected.

Version

1a7f31f / current

Steps to Reproduce

Run a rest server and compare curl -G "http://<serverUrl>/gov/proposals?page=1&limit=3" with curl -G "http://<serverUrl>/gov/proposals?page=2&limit=3" -- the results will be the same.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants