Support blockHeight query in GET /txs

[jbibla]

for displaying all tx's in a particularly block specified by height.

see luniehq/lunie#454 for context.

✌️

[jackzampolin]

Can't you currently do this with the GET /txs endpoint right now? I guess this depends on whether or not you can use tags to search for a specific block. If you can't then it sounds like the solution here is to add an affordance (/txs?blockHeight=$FOO) to enable this search. Does that work @jbibla?

[jbibla]

let me confirm with @faboweb

[faboweb]

/txs?blockHeight=$FOO sounds like the way to go 👍

[jackzampolin]

Was chatting with @fedekunze and he mentioned there is a way to do this.

[alexanderbez]

We should also support by hash.

[alexanderbez]

Just to confirm, we want to be able to get all (decoded) txs for a particular block height or hash, correct @jbibla @jackzampolin?

[fedekunze]

@alexanderbez I think we can already query txs by height using /txs?tx.height=<block> and by hash using /txs/{hash}. Idk if we have tests and proper docs tho...

EDIT: Ideally we should have /txs?height=<block> instead of tx.height

[jackzampolin]

@fedekunze and we have a report here that the tx.height query isn't working.

[alexanderbez]

Im confused. Is the goal here just to rename the query param?

@jackzampolin that issue seems to suggest the community members wants decoded txs, which is what I asked above. Or am I misunderstanding?

[fedekunze]

Idk this issue has been open for a while already, probably it wasn’t implemented back then

[fedekunze]

Actually I think #2894 fixes this issue

[alexanderbez]

Great! Can we update that PR to reference that it closes this one?

[fedekunze]

👍