Remove DelegatorAddress from Msg CreateValidator

[Guy1m0]

For the type MsgCreateValidator, it has the following logic in ValidateBasic

But when calls its GetSigners(), it checks again if the two address, ValidatorAddress and DelegatorAddress, are equal.

Therefore, I think the later if-condition might be redundant

[alexanderbez]

I don't think this is quite right. See my response here: #4638 (review)

[rigelrozanski]

It looks as though there is a bit of an inconsistency in the staking logic here.

• The first check prevents different delegator and validator addresses from being used
• The second check redundantly checks if the addresses are different (which they can't be due to the first check) - and adds multiple addresses to get signers if so.

This looks as though it is leftover code from the idea of "create-validator-on-behalf-of" logic. I recommend we move the DelegatorAddress from the message structure as @alexanderbez suggested in the PR review

[alexanderbez]

Do you mind amending the PR @Guy1m0?

[Guy1m0]

Feel free. And I think moving the DelegatorAddress is more reasonable.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.