-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: remove BlockHeight in context #4580
R4R: remove BlockHeight in context #4580
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4580 +/- ##
==========================================
+ Coverage 52.61% 52.65% +0.04%
==========================================
Files 263 263
Lines 16464 16463 -1
==========================================
+ Hits 8662 8669 +7
+ Misses 7154 7146 -8
Partials 648 648 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far so good - I'd test the BlockHeight()
return value after a WithBlockHeight()
call
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, thanks @colin-axner. Can we add a quick unit test in context_test.go
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
closes #4578
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added a relevant changelog entry:
clog add [section] [stanza] [message]
rereviewed
Files changed
in the github PR explorerFor Admin Use: