Move /bank/balances/{address} REST endpoint into /x/bank #4570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessio
changed the title
x/bank now provides a Querier too. Closes: #4560
alessio
force-pushed
the
alessio/bank-querier
branch
from
6048e9f
to
e45f12a
Compare
sabau
reviewed
Jun 17, 2019
Codecov Report
@@ Coverage Diff @@
## master #4570 +/- ##
==========================================
+ Coverage 52.65% 52.68% +0.03%
==========================================
Files 261 263 +2
Lines 16410 16427 +17
==========================================
+ Hits 8640 8655 +15
- Misses 7124 7125 +1
- Partials 646 647 +1 |
alexanderbez
suggested changes
Jun 18, 2019
fedekunze
previously requested changes
Jun 18, 2019
Co-Authored-By: Alexander Bezobchuk <[email protected]>
|
Because clients depend on this endpoint @fedekunze :) |
sabau
reviewed
Jun 18, 2019
| @@ -17,6 +16,7 @@ import ( | |||
| // RegisterRoutes - Central function to define routes that get registered by the main application | |||
| func RegisterRoutes(cliCtx context.CLIContext, r *mux.Router) { | |||
| r.HandleFunc("/bank/accounts/{address}/transfers", SendRequestHandlerFn(cliCtx)).Methods("POST") | |||
| r.HandleFunc("/bank/balances/{address}", QueryBalancesRequestHandlerFn(cliCtx)).Methods("GET") | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4560
docs/)clog add [section] [stanza] [message]Files changedin the github PR explorerFor Admin Use: