-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow splitting withdrawal txs #4384
Conversation
Co-Authored-By: Alessio Treglia <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor nit, otherwise LGTM 👌
I may actually renege my statement on making this functionality only available to this command. Would you still be in favor of applying this to all commands?
Co-Authored-By: Alexander Bezobchuk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good changes! should tidy the code just a wee bit
Due to HSM limitations (Ledger Nano S), big transactions such as withdrawing rewards from a large number of validators, may be rejected to due memory constraints.
This PR introduces an additional flag that allows splitting the withdrawal messages and generates several transactions. Users can then define the maximum number of messages that they want to use.
This is related to: https://github.com/cosmos/ledger-cosmos/issues/143
While we have extended limits to Nano X in the next release, it is important to provide an alternative to users of Nano S.
docs/
)clog add [section] [stanza] [message]
Files changed
in the github PR explorerFor Admin Use: