Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge gaiareplay into gaiad to reduce number of binaries #4272

Merged
merged 3 commits into from
May 6, 2019

Conversation

alessio
Copy link
Contributor

@alessio alessio commented May 5, 2019

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alessio alessio marked this pull request as ready for review May 5, 2019 17:06
@alessio alessio requested review from fedekunze and sabau May 5, 2019 17:06
@codecov
Copy link

codecov bot commented May 5, 2019

Codecov Report

Merging #4272 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4272   +/-   ##
=======================================
  Coverage   59.09%   59.09%           
=======================================
  Files         217      217           
  Lines       14595    14595           
=======================================
  Hits         8625     8625           
  Misses       5332     5332           
  Partials      638      638

Copy link
Contributor

@sabau sabau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more step on the path towards simplification 👍

@alessio alessio merged commit 5060187 into master May 6, 2019
@alessio alessio deleted the alessio/merge-gaiareplay branch May 6, 2019 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants