Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCD /slashing/signing-infos endpoint not returning all validators #4194

Closed
4 tasks
kwunyeung opened this issue Apr 26, 2019 · 1 comment · Fixed by #4292
Closed
4 tasks

LCD /slashing/signing-infos endpoint not returning all validators #4194

kwunyeung opened this issue Apr 26, 2019 · 1 comment · Fixed by #4292
Assignees
Milestone

Comments

@kwunyeung
Copy link
Contributor

Summary of Bug

The LCD /slashing/signing-infos endpoint only return 100 validators info nomatter how large the limit is set. And the return results don't indicate which object is for which validator. You cannot identify which signing-info belongs to which validator.

Version

v0.34.2

Steps to Reproduce

https://stargate.cosmos.network/slashing/signing_infos?page=1&limit=120

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@alexanderbez
Copy link
Contributor

The reason this happens is not because of an error in pagination, but because rpc.GetValidators(cliCtx, &height) always returns the max bonded validators (ie. 100).

I think we can make a few changes here:

  1. Since the slashing keeper has the validator set, we can iterate over all validators and paginate properly
  2. Fix pagination (it's broken on this endpoint)
  3. Include the validator addresses in the responses

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants